Fix intermittently failing ChunkedDownloadSpec #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkokar
requested review from
kvosper,
dvlato and
VivianLopes
and removed request for
kvosper
kvosper
approved these changes
Aug 30, 2018
dvlato
approved these changes
Aug 30, 2018
dvlato
reviewed
Aug 30, 2018
pom.xml
Outdated
| @@ -92,7 +92,7 @@ | |||
| <netty-tcnative.classifier>linux-x86_64</netty-tcnative.classifier> | |||
|
|
|||
| <!-- General Versions --> | |||
| <guava.version>16.0.1</guava.version> | |||
| <guava.version>18.0</guava.version> | |||
There was a problem hiding this comment.
Should this change be included in this PR?
dvlato
reviewed
Aug 30, 2018
| @@ -44,12 +46,14 @@ class ChunkedDownloadSpec extends FunSpec | |||
| with TestClientSupport | |||
| with Eventually { | |||
|
|
|||
| val (originOne, originOneServer) = originAndCustomResponseWebServer("NettyOrigin") | |||
| val (originOne, originOneServer) = originAndCustomResponseWebServer("NettyOrigin-01") | |||
There was a problem hiding this comment.
The solution is fine but I would expect that we just create the origin in each test / setup method if they can't be reused?
There was a problem hiding this comment.
It is the styx server that would have to be created in each test/setup cycle.
There was a problem hiding this comment.
That's also possible, but I was just thinking of limiting the scope of the origins ( they can be created with ,e.g., a random name in each test). But since , as you say, there's only one Styx instance it makes sense to set all of them up in the fixture.
…ateway read timeout." test by adding a separate origin whose metrics are not influenced by the preceding two tests.
mikkokar
force-pushed
the
fix-failing-ChunkedDownloadSpec
branch
from
b7430e0 to
e73c1fb
Compare
mikkokar
added a commit
to mikkokar/styx
that referenced
this pull request
Oct 3, 2018
Fix "Proxies long lasting HTTP Chunked downloads without triggering gateway read timeout." test by adding a separate origin whose metrics are not influenced by the preceding two tests. (cherry picked from commit 8bed0dc)
mikkokar
added a commit
that referenced
this pull request
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an intermittently failing end-to-end test.
Root cause: Failing assertion was based on origin metrics. However the origin was shared with two other tests which influenced the asserted metric values.
The fix is to add a new backend service that is only used in the failing test, preventing other tests to influence the origin metrics, thus affecting the assertions.