This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
python3: don't run ensurepip during build #41544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to run ensurepip, which installs an old version of pip; we take care of this ourselves in postinstall. On flat (i.e. non-Framework) builds, ensurepip causes an error in postinstall because the pip-3.4 script already exists in prefix/bin. Will resolve Linuxbrew/legacy-linuxbrew#469.
This is the default setting for python 2.7, but we're applying this change to python3, so we may as well apply the symmetric change here in case the default changes in future micro releases.
|
I'll merge Homebrew into Linuxbrew once this PR is merged into Homebrew. |
|
Done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to run ensurepip, which installs an old version of pip; we
take care of this ourselves in postinstall.
On flat (i.e. non-Framework) builds, ensurepip causes an error in
postinstall because the pip-3.4 script already exists in prefix/bin.
Will resolve Linuxbrew/legacy-linuxbrew#469.