Test or_later formula changes.

[MikeMcQuaid]

When the diff contains an or_later bottle change then don’t try to
build the bottle but just install it and test it that way.

CC @ilovezfs for thoughts.

[ilovezfs]

It seems like it should be using json merges rather than manually editing bottle blocks, which we've emphasized as verboten.

[MikeMcQuaid]

Can you elaborate more on "json merges"? In the short-term: do you object to this approach to verify if this is going to work for us? Happy to iterate on the workflow if it proves annoying but would be good to be able to use this for some more Sierra bottles temporarily.

[ilovezfs]

I mean this jazz https://github.com/Homebrew/homebrew-test-bot/blob/master/cmd/brew-test-bot.rb#L968-L984 and the obverse in pull https://github.com/Homebrew/brew/blob/master/Library/Homebrew/dev-cmd/pull.rb#L201-L218.

[MikeMcQuaid]

Yeh, I see. In this case I think although it's different it's a feature because it doesn't require us to rebuild/reupload the bottle.

[ilovezfs]

I don't think we'd need to rebuild/reupload to go through brew pull for this.

In the short-term: do you object to this approach to verify if this is going to work for us?

As long as (A) we know the build fails on 10.12 and (B) the bottle goes through CI in some form before getting an or_later stamp, I think whatever works is fine in the short-run.

But I'd prefer to see these go through brew pull / git push, no upload/download of bottles involved, and the commit be attributed to test-bot not a maintainer.

[MikeMcQuaid]

As long as (A) we know the build fails on 10.12 and (B) the bottle goes through CI in some form before getting an or_later stamp, I think whatever works is fine in the short-run.

Yep, this will allow us to do this.

But I'd prefer to see these go through brew pull / git push, no upload/download of bottles involved, and the commit be attributed to test-bot not a maintainer.

I'd rather avoid modifying e.g. brew pull for this weird case if not necessary.

[ilovezfs]

I'd rather avoid modifying e.g. brew pull for this weird case if not necessary.

I think it depends how many we're talking about. Given there are 65 left on Homebrew/homebrew-core#6408 and maybe at most 1/4th of them actually need this right now, it's probably moot for the time being.