go: various #7924
Closed
go: various #7924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilovezfs
reviewed
Dec 16, 2016
| Language::Go.stage_deps resources, gopath/"src" | ||
|
|
||
| # Fix for Go 1.7+ syntax strictness. Upstream is dead. |
There was a problem hiding this comment.
I'm not sure. Typically for simple syntax errors like this we've fixed it and reported it upstream even where upstream hasn't committed in upwards of 6 months, but upstream has hard deprecated the repo, there's almost nothing in it now, you have to go back to the old tag to find the contents.
I'm open to the simple fix or death either way, but there don't seem to be any issues beyond the lack of = in the prior tag.
There was a problem hiding this comment.
41 installs in the last month, 722 since July, so I guess we can keep it ...
|
Thanks for the 🎁 I guess we'll leave the terraform mess to upstream? |
ilovezfs
reviewed
Dec 16, 2016
| # deciding whether to add a = or not on the ldflags, as mandated | ||
| # by Go 1.7+. | ||
| # https://github.com/rackspace/rack/issues/446 | ||
| inreplace "script/build", "go1.5", "go#{Formula["go"].version}" |
There was a problem hiding this comment.
I think this will break for HEAD
There was a problem hiding this comment.
Oh ugh, yeah, good catch. I guess Utils.popen_read on the go executable itself is an alternative.
There was a problem hiding this comment.
You may be able to get away with Formula["go"].stable.version
There was a problem hiding this comment.
Aye, I was just trying to not bork it for devel. version is nice because it works whatever you have installed. The upstream build script doesn't seem to have contemplated that there would be a Go beyond 1.5; it does a simple grep to see if we need the = or not.
There was a problem hiding this comment.
Utils.popen_read sounds 🆒
ilovezfs
reviewed
Dec 16, 2016
| @@ -18,87 +18,18 @@ class Serf < Formula | |||
| end | |||
|
|
|||
| depends_on "go" => :build | |||
| depends_on "govendor" => :build | |||
There was a problem hiding this comment.
Do the deps end up exactly the same with govendor+gox as compared to the current formula in master? If not, may want to revision bump.
There was a problem hiding this comment.
I'll double check, but given how (not so) often people update resources hardcoded into formulae I suspect it's not in sync.
ilovezfs
reviewed
Dec 16, 2016
| cd gopath/"src/github.com/hashicorp/serf" do | ||
| # We've already handled downloading/building these | ||
| # and don't need to repeat the step. | ||
| inreplace "GNUmakefile", "bin:: tools", "bin::" |
There was a problem hiding this comment.
worth reporting as a feature request? (presumably it could check if gox is already in the PATH)
There was a problem hiding this comment.
I'll double check if this is needed actually. I put this in first, and then messed with the gox stuff a bit more, it might be redundant now. Upstream do have some sane logic around finding gox on system first.
ilovezfs
approved these changes
Dec 16, 2016
Was updated yesterday, so I presumed if it passed CI as the new version it was 💯 now. Will double check but fingers crossed. |
|
Oh, that's fun 😭. |
|
Pushed some changes. Should be alright now, more or less. |
|
Thanks Dom. I love my 🎁 :) 🚀 |
|
I made it just for you 😺. Having a real pain reproducing the |
|
Odd, I'm still able to reproduce the original issue on demand (which is distinct from the Sierra failure https://bot.brew.sh/job/Homebrew%20Core/13240/version=sierra/console): |
|
Apparently it's a race does wonders. 🙈 |
|
I er, ran it again through twice more with no problems. And then ran it a third more time, and encountered this 😅: But then I did a forth build and that worked fine again: Who even knows. |
|
That smells like a parallelization issue to me, but I think it's equally likely this formula is just cursed by demonic spirits. |
|
Aye, someone's cursed the |
|
It's got nothin' on the android-sdk formula, though: #7860. |
|
Oh, those formulae were periodically joyful. Upstream binaries don't always play so well with Homebrew sigh. The |
|
Sounds like white space PTSD to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Present for @ilovezfs.
Closes #7631.