liblastfm: qt5 support and add a test #6740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
requested changes
Nov 9, 2016
|
|
||
| test do | ||
| cp_r "#{share}/tests/.", testpath | ||
| assert_match "Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 0ms", |
There was a problem hiding this comment.
0ms needs removed here as it's failing on Sierra (and generally is likely to be flaky). Is it not enough to rely on the exit-code alone here?
There was a problem hiding this comment.
You're right, exit-code should be enough.
MikeMcQuaid
approved these changes
Nov 10, 2016
|
Thanks again for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Related to #1705 and #6408.