Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of ipbt #6637

Closed
wants to merge 1 commit into from
Closed

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Nov 5, 2016

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Previous version tar.gz wasn't available anymore. Updated to the new version. This should also fix the sierra bottle issue #6408 for this formula.

@ilovezfs
Copy link
Contributor

ilovezfs commented Nov 6, 2016

I don't think we need to override the version here.

@dunn dunn added the needs response Needs a response from the issue/PR author label Nov 6, 2016
@Moisan
Copy link
Member Author

Moisan commented Nov 6, 2016

@ilovezfs Without the override, the default version is 0.

@BrewTestBot BrewTestBot removed the needs response Needs a response from the issue/PR author label Nov 6, 2016
@MikeMcQuaid
Copy link
Member

@ilovezfs FYI audit will 💥 if a version is specified unnecessarily.

@MikeMcQuaid
Copy link
Member

Thanks again for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

For future reference the preferred commit message format is ipbt 20160908. Please complete the issue template in future PRs where this format is detailed in the linked Contributing guidelines. Thanks!

@ilovezfs
Copy link
Contributor

ilovezfs commented Nov 7, 2016

I guess the prior version scanned correctly because the git hash coincidentally had no a-f in the hex. Yikes, and then some more yikes.

@ilovezfs
Copy link
Contributor

ilovezfs commented Nov 7, 2016

@ilovezfs FYI audit will 💥 if a version is specified unnecessarily.

@MikeMcQuaid Yes, I know. The prior version scans as 20141026.2197432 so a version "20141026" would not be redundant.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants