Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capnp: vendor gtest #5773

Closed
wants to merge 2 commits into from
Closed

capnp: vendor gtest #5773

wants to merge 2 commits into from

Conversation

dunn
Copy link
Contributor

@dunn dunn commented Oct 11, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --new-formula <formula> (after doing brew install <formula>)?

Fixes #5435.

@zmwangx
Copy link
Contributor

zmwangx commented Oct 11, 2016

CI is seeing the same test failure as I did:

The following tests FAILED:
      2 - kj-heavy-tests-run (Failed)

Only on Sierra.

@dunn
Copy link
Contributor Author

dunn commented Oct 11, 2016

Ohhh; I was testing on El Cap. Dang.

@dunn
Copy link
Contributor Author

dunn commented Oct 11, 2016

The release we're trying to build is so old that I don't think that test even exists in the current master: https://github.com/sandstorm-io/capnproto/tree/master/c%2B%2B/src/kj

@zmwangx
Copy link
Contributor

zmwangx commented Oct 11, 2016

Yeah as I said in the other thread, gtest was yanked out completely.

@zmwangx
Copy link
Contributor

zmwangx commented Oct 11, 2016

Unfortunately the master branch seems to also fail the same test: capnproto/capnproto#375. (I didn't test it locally because the formula might need substantial modifications to work with master — at least merely running ./release.sh doesn't work.)

@dunn dunn added the upstream issue An upstream issue report is needed label Oct 11, 2016
@zmwangx
Copy link
Contributor

zmwangx commented Dec 2, 2016

@paulproteus, member of sandstorm-io (parent org of capnp), claims that it's not essential to pass all tests (if I understood him correctly). Guess we can yank out make check.

@dunn
Copy link
Contributor Author

dunn commented Dec 2, 2016

¯\_(ツ)_/¯ ok

@MikeMcQuaid
Copy link
Member

Thanks @dunn!

@kentonv
Copy link

kentonv commented Dec 13, 2016

FWIW the test failures here appear to be because Apple shipped a broken kernel. The test failures are very real, but it's the OS that's broken. What does one do in such a case? :/

@zmwangx
Copy link
Contributor

zmwangx commented Dec 13, 2016

File a radar.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants