flutter 1.9.1 (new formula) #46727
flutter 1.9.1 (new formula) #46727
Conversation
|
A Flutter manages itself in a mainstream repository, so it must be a complete git clone under flutter file tree. |
| class Flutter < Formula | ||
| desc "Google’s UI toolkit for mobile, web, and desktop from a single codebase" | ||
| homepage "https://flutter.dev" | ||
| url "https://storage.googleapis.com/flutter_infra/releases/stable/macos/flutter_macos_v1.9.1+hotfix.6-stable.zip" |
There was a problem hiding this comment.
Homebrew core builds from source, or installs cross-platform binaries. See https://docs.brew.sh/Acceptable-Formulae
There was a problem hiding this comment.
Thank you for the code review
Corrected as pointed out, the proper way is to change the PR to homebrew cask, but I have found similar PR in the past.
And it has come to the point of sending PR to the homebrew formulae.
Please tell me which is the best method.
Homebrew/homebrew-cask#63170
There was a problem hiding this comment.
If it doesn't build from source it can't be a formula in homebrew-core. If you want to submit it as a cask or make a formula in a private tap is up to you.
There was a problem hiding this comment.
While this submission doesn’t build from source, I see no indication it can’t be done.
There was a problem hiding this comment.
@fxcoudert and @SMillerDev
What is your opinion on HomeBrew's permanent solution to pr for packages that don't have a GUI and are not built from source, like this one?
There was a problem hiding this comment.
@fxcoudert and @SMillerDev and @vitorgalvao
I want to hear the final opinion of the homebrew team.
Does it mean that HomeBrew, even if it comes with pre-built binaries, must be rebuilt to be included in the package? Also, if I modify it as a formulae to build the flutter engine, will it be merged?
There was a problem hiding this comment.
If something can't build from source it could be a cask. If it can it can be a formula in homebrew-core. For that to happen, the rules that were linked twice already must be followed, including but not limited to building the software from source. As for it getting merged, that depends on if you write a formula of sufficient quality to include it in homebrew-core. I can't give any guarantee on merging it before you start.
There was a problem hiding this comment.
"If something can't build from source it could be a cask."
This doesn't seem to be the case, and this seems to be rejected for CUI-only binaries.
In other words, HomeBrew potentially has the disadvantage of being unacceptable in both the core and the cask, regardless of the popularity of the tool that sent the PR.
Regarding the creation of formulae including redundant builds, we will consider modifying this PR.
There was a problem hiding this comment.
"If something can't build from source it could be a cask."
This doesn't seem to be the case
It is the case, because it isn’t true that this can’t be built from source. Or it is true, that point hasn’t been made with a justification.
HomeBrew potentially has the disadvantage of being unacceptable in both the core and the cask, regardless of the popularity of the tool that sent the PR.
Barring special situations, if a tool is popular enough and it can be built from source, it will be added to Homebrew when someone submits it. If no one does and there’s no reason not too, it wasn’t that popular to our user base.
There was a problem hiding this comment.
Thank you for this bikeshedding session. None of this applies to flutter, it's well known and popular and builds from source and there has been plenty of explanation what the requirements are for the formula. If you have a pull request that builds from source we can reconsider.
This was indicated very clearly by @vitorgalvao in Homebrew/homebrew-cask#63170 (comment) For open source CLI-only tools, the options are:
I'm closing for now, we have given ample guidance here and above. Please feel free to reopen a PR once you have a working formula that builds from source. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?