Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygobject3: partially revert b3a1ab364f #19186

Closed
wants to merge 1 commit into from
Closed

pygobject3: partially revert b3a1ab364f #19186

wants to merge 1 commit into from

Conversation

DomT4
Copy link
Contributor

@DomT4 DomT4 commented Oct 8, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Moving to the:

system python, *Language::Python.setup_install_args(prefix)

method removed both the installation of the header & the pkg-config files, which has caused various issues. Unless anyone has a solution here we should just revert the change for now.

Moving to the:
```
system python, *Language::Python.setup_install_args(prefix)
```
method removed both the installation of the header & the pkg-config
files, which has caused various issues. Unless anyone has a solution
here we should just revert the change for now.
@ilovezfs
Copy link
Contributor

ilovezfs commented Oct 9, 2017

🎉 🐍

@ilovezfs ilovezfs closed this in 1c040ed Oct 9, 2017
@DomT4
Copy link
Contributor Author

DomT4 commented Oct 9, 2017

Should be safe to close #18859 now, as well.

Not just guessing, I add, despite the way I phrased that 😄.

==> Summary
🍺  /usr/local/Cellar/gst-python/1.12.2: 16 files, 416.2KB, built in 19 seconds

@DomT4 DomT4 deleted the pygobject3 branch October 9, 2017 02:13
@DomT4
Copy link
Contributor Author

DomT4 commented Oct 9, 2017

And #18709 lol.

@DomT4
Copy link
Contributor Author

DomT4 commented Oct 9, 2017

Should've remembered to stick those in the commit message beforehand, sorry.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants