Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdu: remove conflict with coreutils #134731

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

dundee
Copy link
Contributor

@dundee dundee commented Jun 23, 2023

the binary was renamed

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 23, 2023
@dundee
Copy link
Contributor Author

dundee commented Jun 23, 2023

Please add CI-syntax-only label.

@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jun 23, 2023
@carlocab
Copy link
Member

Thanks. Could you split your commit into two? Each commit should only modify exactly one formula.

dundee added 2 commits June 23, 2023 13:11
the binary was renamed
the gdu binary was renamed
@dundee dundee force-pushed the dundee/feat/gdu-conflict branch from 7958864 to 5b9db6c Compare June 23, 2023 11:12
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jun 23, 2023
@dundee
Copy link
Contributor Author

dundee commented Jun 23, 2023

Thanks. Could you split your commit into two? Each commit should only modify exactly one formula.

Sure, done. Thanks!

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@carlocab carlocab enabled auto-merge June 23, 2023 11:19
@carlocab carlocab added this pull request to the merge queue Jun 23, 2023
Merged via the queue into Homebrew:master with commit a52d8c3 Jun 23, 2023
@dundee dundee deleted the dundee/feat/gdu-conflict branch June 23, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants