Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig 0.10.0 #114382

Closed
wants to merge 4 commits into from
Closed

zig 0.10.0 #114382

wants to merge 4 commits into from

Conversation

chenrui333
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Oct 31, 2022
@chenrui333
Copy link
Member Author

cargo-zigbuild test failure, I could not reproduce in my local.

@messense
Copy link
Contributor

messense commented Nov 1, 2022

cargo-zigbuild test failure, I could not reproduce in my local.

Looks like the error is coming from semver: https://github.com/dtolnay/semver/blob/3a2fd6f8aa7c6d7dbc7550851bfd9c28767820a1/tests/test_version.rs#L17

What's the output of zig version?

Formula/zig.rb Outdated Show resolved Hide resolved
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 1, 2022
@carlocab
Copy link
Member

carlocab commented Nov 1, 2022

cargo-zigbuild test failure, I could not reproduce in my local.

Fixed now.

However, it looks like we need zig to use -headerpad_max_install_names when linking. Not sure if there's a way to do this (or if it's even supported in zld).

@carlocab carlocab added the CI-linux-self-hosted Build on Linux self-hosted runner label Nov 1, 2022
@carlocab
Copy link
Member

carlocab commented Nov 1, 2022

Ok, zig supports it as of 0.10: ziglang/zig@589bf67

Still need to work out how to get the build to use it though.

@carlocab
Copy link
Member

carlocab commented Nov 1, 2022

Fails to build on Catalina. Support dropped. ziglang/zig#13313

@carlocab carlocab added build failure CI fails while building the software 10.15 Catalina is specifically affected labels Nov 1, 2022
carlocab
carlocab previously approved these changes Nov 1, 2022
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Nov 1, 2022
Formula/zig.rb Outdated Show resolved Hide resolved
carlocab
carlocab previously approved these changes Nov 1, 2022
@carlocab carlocab dismissed their stale review November 1, 2022 13:30

CI not complete

@carlocab carlocab removed the build failure CI fails while building the software label Nov 1, 2022
@carlocab
Copy link
Member

carlocab commented Nov 1, 2022

It will be when the bottles are built. Merging it right now means no bottles, and consequently brew upgrade and brew install errors for users.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@sam701
Copy link

sam701 commented Nov 1, 2022

I have this error after brew upgrade zig on Monterey 12.5.1:

$ zig version
dyld[84476]: Library not loaded: '/usr/local/opt/z3/lib/libz3.4.11.dylib'
  Referenced from: '/usr/local/Cellar/zig/0.10.0/bin/zig'
  Reason: tried: '/usr/local/opt/z3/lib/libz3.4.11.dylib' (no such file), '/usr/local/lib/libz3.4.11.dylib' (no such file), '/usr/lib/libz3.4.11.dylib' (no such file), '/usr/local/Cellar/z3/4.11.2/lib/libz3.4.11.dylib' (no such file), '/usr/local/lib/libz3.4.11.dylib' (no such file), '/usr/lib/libz3.4.11.dylib' (no such file)
fish: Job 1, 'zig version' terminated by signal SIGABRT (Abort)

@smbl64
Copy link

smbl64 commented Nov 1, 2022

brew reinstall z3

fixed the problem with libz3.4.11.dylib for me.

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
@chenrui333 chenrui333 deleted the bump-zig-0.10.0 branch March 12, 2023 07:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
10.15 Catalina is specifically affected bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants