Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formulae missing High Sierra bottles #18493

Closed
85 tasks done
fxcoudert opened this issue Sep 24, 2017 · 49 comments
Closed
85 tasks done

Formulae missing High Sierra bottles #18493

fxcoudert opened this issue Sep 24, 2017 · 49 comments
Labels
10.13 High Sierra is specifically affected

Comments

@fxcoudert
Copy link
Member

fxcoudert commented Sep 24, 2017 •
edited
Loading

Remaining

Top formulas (> 200 installs a month)

(sorted by usage)

Done, 13 March 2018

Other formulas

Done
@ilovezfs ilovezfs added the 10.13 High Sierra is specifically affected label Sep 24, 2017
@ilovezfs ilovezfs mentioned this issue Sep 24, 2017
Closed
@ilovezfs ilovezfs added the help wanted Task(s) needing PRs from the community or maintainers label Sep 24, 2017
@ilovezfs ilovezfs changed the title Formulas missing High Sierra bottle Formulae missing High Sierra bottles Sep 24, 2017
@zmwangx
Copy link
Contributor

zmwangx commented Sep 24, 2017 •
edited
Loading

Ha, didn't realize they removed 2to3. While Python 2.7 is 2.5 years from final death and even the most entrenched are moving to Python 3, Apple is backing away.

(Feel free to delete this lament.)

@ilovezfs
Copy link
Contributor

There is now 2to3- and 2to3-2.7

@zmwangx
Copy link
Contributor

zmwangx commented Sep 24, 2017

Oh yeah, I missed those. What the heck is 2to3-...

@ilovezfs
Copy link
Contributor

@zmwangx no idea. I could come up with theories but the only one that seems plausible is that someone hit the wrong key on their keyboard.

@zmwangx
Copy link
Contributor

zmwangx commented Sep 24, 2017

They do something funny with 2to3: https://opensource.apple.com/source/python/python-97.50.7/Makefile.auto.html

@ilovezfs
Copy link
Contributor

I guess 2to3- isn't actually new though

@zmwangx
Copy link
Contributor

zmwangx commented Sep 24, 2017

No it's not. At least it's present on 10.12.

@zmwangx
Copy link
Contributor

zmwangx commented Sep 24, 2017 

$ ls /usr/bin/2to3*
/usr/bin/2to3  /usr/bin/2to3-  /usr/bin/2to3-2.7  /usr/bin/2to32.6

@ilovezfs
Copy link
Contributor

Going to mass replace 2to3 to 2to3- until I get around to converting those to patches #18501 so that we can haz bottles.

@SMillerDev
Copy link
Member

Gearman doesn't seem to compile on high Sierra, as mentioned here: https://github.com/Homebrew/homebrew-php/pull/4447 so that can either be checked or crossed of.

@scpeters
Copy link
Contributor

I've tested bullet on high sierra, and it builds from source fine. This issue says help wanted, but I'm not sure how you build bottles for the new OS release. I haven't seen pull requests; I just see commits from @BrewTestBot that are merged by a maintainer. Not sure if there's anything I can do.

@fxcoudert
Copy link
Member Author

@scpeters bullet fails to build on our CI machines. This is due to b3GjkPairDetector.cpp failing to compile with Xcode9's clang when -target-cpu core2 (or -march=core2) is passed.

@ilovezfs
Copy link
Contributor

@SMillerDev this list represents things that do not have bottles on High Sierra. So none of them built. If the box is checked that means there's no longer an issue, and the formula has a bottle now or the formula has been deleted. So gearman being on the list without a check mark already conveys the fact that it doesn't build on 10.13.

@SMillerDev
Copy link
Member

Right, I thought it was just things that didn't happen to have one yet. My bad.

@ilovezfs
Copy link
Contributor

@SMillerDev ah, I see. No worries. Just didn't want you to think we were ignoring you :)

@lugray
Copy link
Contributor

lugray commented Sep 28, 2017

I found a hacky way to build libgda on High Sierra for anyone else who comes looking. It should also provide some insight into how to fix it properly:

  1. Apply patch to /usr/local/opt/glib/bin/glib-mkenums to deal with latin-1 encoded libgda files:
410a411,415
>     if curfilename.startswith("gda-") or curfilename.startswith("libgda-"):
>         encoding = "latin-1"
>     else:
>         encoding = "utf-8"
>
412c417
<         curfile = io.open(curfilename, encoding="utf-8")
---
>         curfile = io.open(curfilename, encoding=encoding)
  1. In shell, make mysql libraries findable when libgda goes looking for them in the wrong places (replace 5.7.10 below with whichever mysql client version you have):
brew install mysql
cd /usr/local/include/
for f in ../Cellar/mysql-client/5.7.10/include/mysql/*.h; do ln -s "$f"; done
cd mysql
ln -s mysql/psi
for f in mysql/*.h; do ln -s "$f"; done
brew install libgda

@scpeters scpeters mentioned this issue Sep 28, 2017
Closed
@scpeters
Copy link
Contributor

@fxcoudert thanks for the info about bullet. It compiled fine with -march=native, but I was able to reproduce the problem with -march=core2. I tinkered with flags and it seems to be fine with -O1 and lower, but clang just takes forever with -O2 and higher. I've reported it upstream to bullet bulletphysics/bullet3#1347

@erwincoumans
Copy link

erwincoumans commented Sep 28, 2017 •
edited
Loading

How are you building Bullet exactly? I'm using cmake or premake usually, and both work out-of-the-box fine with Bullet on High Sierra, but there isn't a flag -march=core2 in neither of those build systems. So how would I reproduce the issue using any of the default Bullet build systems?

Also, what is the output of clang --version?

@scpeters
Copy link
Contributor

@erwincoumans The bullet homebrew formula uses cmake and the -march= compiler flags are supplied by brew to ensure support for a wide range of supported CPU architectures. We can continue discussion in bulletphysics/bullet3#1347 unless you have specific questions for the homebrew maintainers.

@fxcoudert fxcoudert mentioned this issue Oct 2, 2017
Closed
@CamJN
Copy link
Contributor

CamJN commented Oct 2, 2017

fix for bdsup2sub #18716 and a fix for passenger is coming but we're trying to squeeze in some other things to the release too.

This was referenced Oct 2, 2017
Closed
Closed
Closed
Closed
@offlinenow
Copy link

For passenger, just add dependence httpd and apr when building with apache2 module

@s172262 s172262 mentioned this issue Oct 29, 2017
Merged
4 tasks
ilovezfs pushed a commit that referenced this issue Oct 30, 2017
@s172262 @ilovezfs
glslang: backport patches for Xcode 9 (#20006)
1b16809 
For KhronosGroup/glslang#1083 (#18493)
robohack pushed a commit to robohack/homebrew-core that referenced this issue Nov 3, 2017
@s172262
glslang: backport patches for Xcode 9 (Homebrew#20006)
66c534c 
For KhronosGroup/glslang#1083 (Homebrew#18493)
@thinker0 thinker0 mentioned this issue Nov 13, 2017
Closed
4 tasks
@ilovezfs ilovezfs mentioned this issue Dec 24, 2017
Closed
@xwkuang5
Copy link

xwkuang5 commented Jan 6, 2018 •
edited
Loading

Hi! I'm on High Sierra (version 10.13.1) and when I try to install OpenCV 3.4 by running the command brew install opencv --with-contrib option, I got the warning from homebrew saying that Warning: opencv: this formula has no --with-contrib option so it will be ignored!. I try doing brew options opencv and nothing shows up. Is this because OpenCV 3.4.0 was only released several weeks ago and no updates have been made to homebrew?

Thanks!

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 6, 2018

it's always built with contrib now

@shakna-israel shakna-israel mentioned this issue Jan 8, 2018
Closed
5 tasks
@pascaldevink pascaldevink mentioned this issue Jan 9, 2018
Closed
@Homebrew Homebrew deleted a comment from Mirocow Jan 9, 2018
@queengooborg queengooborg mentioned this issue Jan 10, 2018
Merged
4 tasks
@queengooborg
Copy link
Contributor

Just created a PR that fixes ucspi-tcp, meaning that there's just one more popular formula to go! (At least, if #22681 is accepted and merged. 😛)

@hazcod
Copy link
Contributor

hazcod commented Jan 10, 2018 •
edited
Loading

What about htop? (#22622)

Might be related to hishamhm/htop#682

@Homebrew Homebrew locked and limited conversation to collaborators Jan 10, 2018
@ablyeom ablyeom mentioned this issue Feb 3, 2018
Closed
@Homebrew Homebrew deleted a comment from SEAPUNK Feb 3, 2018
This was referenced Feb 10, 2018
Closed
Closed
@Homebrew Homebrew unlocked this conversation Feb 10, 2018
@apjanke
Copy link
Contributor

apjanke commented Feb 10, 2018

Some updates:

Are we still doing depends_on MaximumMacOSRequirement? Might be time to slap that on nethacked; the formula's already kind of a mess of hacks.

@ilovezfs
Copy link
Contributor

Are we still doing depends_on MaximumMacOSRequirement?

Only in cases where it's not feasible to backport a fix, but a fix is nonetheless expected or already merged, and at the same time an or_later bottle won't work. For example: valgrind.

@fxcoudert fxcoudert mentioned this issue Mar 11, 2018
Closed
@HesselM HesselM mentioned this issue Mar 13, 2018
Closed
@HesselM
Copy link

HesselM commented Mar 13, 2018

Patched ddd with PR #25233

@fxcoudert
Copy link
Member Author

Thanks to everyone who helped on this enormous task! We've got them all working… well, except a few we removed :)

@ghost ghost removed the help wanted Task(s) needing PRs from the community or maintainers label Mar 13, 2018
@ilovezfs
Copy link
Contributor

A special thanks to @fxcoudert for his tireless and skillful work getting everything patched and bottled for High Sierra.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
10.13 High Sierra is specifically affected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests