Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsidian - Require reinstall of Cask for version v1.8.4 #202014

Closed
3 of 6 tasks
belthesar opened this issue Feb 17, 2025 · 2 comments
Closed
3 of 6 tasks

Obsidian - Require reinstall of Cask for version v1.8.4 #202014

belthesar opened this issue Feb 17, 2025 · 2 comments

Comments

@belthesar
Copy link
Contributor

Verification

Description of issue

Hi folks - opening this issue because I wasn't sure if this made sense as a discussion topic given the security alert sent by Obsidian.

Users of Obsidian that have used in-app upgrades from a previous version to Obsidian v1.8.4 (my full version prior to reinstall: v1.4.16) are receiving an in-application notification from Obsidian that they need to fully reinstall the application in order to receive important security updates to Obsidian. Performing a brew upgrade --cask does not perform this removal as the Cask contains the auto_updates stanza. Users can easily perform this update as required by performing a brew upgrade --cask obsidian --force to force re-downloading and installing Obsidian, however it is my opinion that due to the nature of the security update, the Cask should be modified to perform the update process for users for this version.

I'm not aware if there are mechanisms with Cask formulae to flag users as "normally this autoupdates, but if this latest version according to Homebrew is equal to or newer than the existing version, then perform a full upgrade". If so, I believe this is an appropriate time for this. Barring that, publishing an update to the cask temporarily setting the auto_updates stanza and/or adding a caveats stanza informing users on how to perform the forced upgrade procedure for this version should be provided.

Command that failed

n/a

Output of command with --verbose --debug

n/a

Output of brew doctor and brew config

n/a

Output of brew tap

n/a
@bevanjkay
Copy link
Member

Calling brew upgrade obsidian without the --force flag will upgrade the cask regardless of the auto_updates true. When a cask argument is passed to brew upgrade the auto_updates stanza is ignored as the user has suggested intent to upgrade the specific package.

I don't think there's anything we can do on the Homebrew side in this instance.

@belthesar
Copy link
Contributor Author

Ahh gotcha. It seems that it's only ignored when doing a vanilla brew upgrade (--cask) without specifying the formula/cask. I don't mind that some of this is "learn how Homebrew cask upgrades work," as I was able to work around this problem myself without much issue. I do wonder if there could be additional care to address this kind of situation in the future, but that'd be beyond the scope of this issue. I'll close this issue as a result. Thanks for your time and consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants