keg_relocate: Check HOMEBREW_TEMP's realpath when excluding name changes #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges. Since /tmp (the default HOMEBREW_TEMP) is a symlink to /private/tmp, some build systems (like Parrot's) will attempt to use the realpath instead of the literal /tmp we supply it with. This breaks the relocation code, which only tested the literal HOMEBREW_TEMP and not its realpath.
ilovezfs
approved these changes
Jan 8, 2017
|
This also fixed open-zwave. https://bot.brew.sh/job/Homebrew%20Sierra%20Testing/1185/ Thanks! |
MikeMcQuaid
reviewed
Jan 8, 2017
| next if bad_name.start_with?("/") && !bad_name.start_with?(HOMEBREW_TEMP.to_s) | ||
| next if bad_name.start_with?("/") && | ||
| !bad_name.start_with?(HOMEBREW_TEMP.to_s) && | ||
| !bad_name.start_with?(HOMEBREW_TEMP.realpath.to_s) |
There was a problem hiding this comment.
Will this not 💥 if HOMEBREW_TEMP isn't a symlink?
There was a problem hiding this comment.
you can call realpath on anything
There was a problem hiding this comment.
Yeh, forgot it'll only 💥 on bad symlinks in which case you'll have other problems.
There was a problem hiding this comment.
Ah good to know. So readlink requires a symlink but can read a bad link, and realpath will accept non-symlinks, but dies on a bad link. Sometimes I wonder if these functions are out to get us.
There was a problem hiding this comment.
(I was maybe thinking of readlink...). Yes, they definitely are.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?Since
/tmp(the defaultHOMEBREW_TEMP) is a symlink to/private/tmp,some build systems (like Parrot's) will attempt to use the realpath
instead of the literal
/tmpwe supply it with. This breaks the relocationcode, which only tested the literal
HOMEBREW_TEMPand not its realpath.Fixes parrot bottling in Homebrew/homebrew-core#6408.
Ping @ilovezfs