-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve, define Python library exception list #16662
Conversation
@woodruffw I have some doubts about the |
See Homebrew#16662 We would like to enforce vendoring for Python libraries, or the usage of a virtualenv in the formula's libexec directory, using a virtualenv.
I'm +1 on doing it in a second batch, to keep things small here. |
See Homebrew#16662 We would like to enforce vendoring for Python libraries, or the usage of a virtualenv in the formula's libexec directory, using a virtualenv.
See Homebrew#16662 We would like to enforce vendoring for Python libraries, or the usage of a virtualenv in the formula's libexec directory, using a virtualenv.
See Homebrew#16662 We would like to enforce vendoring for Python libraries, or the usage of a virtualenv in the formula's libexec directory, using a virtualenv.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@iMichka, is there anything you wanted to add/update or are we good to merge? I think the open/unresolved discussions can be handled in next round given that it looks like we were planning another rework?
We can expand any exceptions as necessary. I've created a table of various formulae in Homebrew/homebrew-core#167905 and will be triaging them. |
99c6fb2
to
ecc181c
Compare
@cho-m I resolved the different comments that were made. We can merge as-is and iterate from here, you are right. |
Co-authored-by: Eric Knibbe <[email protected]>
Thanks again @iMichka! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?