Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rows table rows. #107

Closed
Swiftb0y opened this issue Jun 9, 2024 · 0 comments · Fixed by #110
Closed

Missing rows table rows. #107

Swiftb0y opened this issue Jun 9, 2024 · 0 comments · Fixed by #110

Comments

@Swiftb0y
Copy link
Contributor

Swiftb0y commented Jun 9, 2024

As per Deep-Symmetry/crate-digger#32

rekordcrate/src/pdb/mod.rs

Lines 324 to 350 in 01ebd87

let mut row_groups = Vec::with_capacity(num_row_groups.into());
// Calculate number of rows in last row group
let mut num_rows_in_last_row_group = num_rows % RowGroup::MAX_ROW_COUNT;
if num_rows_in_last_row_group == 0 {
num_rows_in_last_row_group = RowGroup::MAX_ROW_COUNT;
}
// Read last row group
let row_group = RowGroup::read_options(
reader,
endian,
(page_type, page_heap_offset, num_rows_in_last_row_group),
)?;
row_groups.push(row_group);
// Read remaining row groups
for _ in 1..num_row_groups {
let row_group = RowGroup::read_options(
reader,
endian,
(page_type, page_heap_offset, RowGroup::MAX_ROW_COUNT),
)?;
row_groups.insert(0, row_group);
}
Ok(row_groups)

Needs fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant