Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changelog and make like case sensitive #2082

Merged
merged 1 commit into from
Dec 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [8.4.0] - Unreleased
## [8.4.0] - 2024-12-02

- Add Ordering to Filters
- [MSSQL ONLY] Add ability to perform Regex redactions on data loads and existing catalogues
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
var cataloguePk = _cataloguePKs.FirstOrDefault(c => c.ColumnInfo.GetRuntimeName() == pk.GetRuntimeName());
qb.AddColumn(new ColumnInfoToIColumn(memoryRepo, cataloguePk.ColumnInfo));
}
qb.AddCustomLine($"{columnInfo.GetRuntimeName()} LIKE '%{_redactionConfiguration.RegexPattern}%'", QueryComponent.WHERE);
qb.AddCustomLine($"{columnInfo.GetRuntimeName()} LIKE '%{_redactionConfiguration.RegexPattern}%' COLLATE Latin1_General_BIN", QueryComponent.WHERE);
if (_readLimit is not null)
{
qb.TopX = (int)_readLimit;
Expand Down Expand Up @@ -132,7 +132,7 @@
{
RegexRedactionHelper.DoJoinUpdate(columnInfo, _discoveredTable, _server, redactionUpdates, _discoveredPKColumns);
}
dt.Dispose();

Check warning

Code scanning / CodeQL

Dispose may not be called if an exception is thrown during execution Warning

Dispose missed if exception is thrown by
call to method GenerateRedactionsDataTable
.
Dispose missed if exception is thrown by
call to method GeneratePKDataTable
.
Dispose missed if exception is thrown by
call to method Discover
.
Dispose missed if exception is thrown by
call to method DiscoverColumns
.
Dispose missed if exception is thrown by
call to method ToArray
.
Dispose missed if exception is thrown by
call to method Where
.
Dispose missed if exception is thrown by
call to method ToList
.
Dispose missed if exception is thrown by
call to method Where
.
Dispose missed if exception is thrown by
call to method AddColumn
.
Dispose missed if exception is thrown by
call to method FirstOrDefault
.
Dispose missed if exception is thrown by
call to method AddColumn
.
Dispose missed if exception is thrown by
call to method AddCustomLine
.
Dispose missed if exception is thrown by
call to method GetRuntimeName
.
Dispose missed if exception is thrown by
call to method BeginLoadData
.
Dispose missed if exception is thrown by
call to method GetConnection
.
Dispose missed if exception is thrown by
call to method Open
.
Dispose missed if exception is thrown by
call to method GetCommand
.
Dispose missed if exception is thrown by
call to method GetDataAdapter
.
Dispose missed if exception is thrown by
call to method Fill
.
Dispose missed if exception is thrown by
call to method Close
.
Dispose missed if exception is thrown by
call to method Clone
.
Dispose missed if exception is thrown by
call to method BeginLoadData
.
Dispose missed if exception is thrown by
call to method Redact
.
Dispose missed if exception is thrown by
call to method EndLoadData
.
Dispose missed if exception is thrown by
call to method ExpectTable
.
Dispose missed if exception is thrown by
call to method Exists
.
Dispose missed if exception is thrown by
call to method Drop
.
Dispose missed if exception is thrown by
call to method CreateTable
.
Dispose missed if exception is thrown by
call to method ExpectTable
.
Dispose missed if exception is thrown by
call to method Exists
.
Dispose missed if exception is thrown by
call to method Drop
.
Dispose missed if exception is thrown by
call to method CreateTable
.
Dispose missed if exception is thrown by
call to method SaveRedactions
.
Dispose missed if exception is thrown by
call to method Drop
.
Dispose missed if exception is thrown by
call to method Drop
.
Dispose missed if exception is thrown by
call to method DoJoinUpdate
.
Dispose missed if exception is thrown by
call to method Dispose
.
}
else
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ protected override void MutilateTable(IDataLoadJob job, ITableInfo tableInfo, Di
var sql = @$"
SELECT {column.GetRuntimeName()} {pkSeparator} {string.Join(", ", pkColumnInfos.Select(c => c.GetRuntimeName()))}
FROM {table.GetRuntimeName()}
WHERE {column.GetRuntimeName()} LIKE '%{RedactionConfiguration.RegexPattern}%'
WHERE {column.GetRuntimeName()} LIKE '%{RedactionConfiguration.RegexPattern}%' COLLATE Latin1_General_BIN
";
var dt = new DataTable();
dt.BeginLoadData();
Expand Down