Task/rdmp-1 Update Ticketing System #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sk/RDMP-1-encryption-length
JFriel
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| var ticketingSystem = WhenIHaveA<TicketingSystemConfiguration>(repository); | ||
| ticketingSystem.SaveToDatabase(); | ||
| return (T)(object)new TicketingSystemReleaseStatus(repository, "my_status", null, ticketingSystem); |
Check warning
Code scanning / CodeQL
Useless upcast Warning
| { | ||
| var cata = WhenIHaveA<Catalogue>(repository); | ||
|
|
||
| var lmd = WhenIHaveA<LoadMetadata>(repository); | ||
|
|
||
| return (T)(object)new LoadMetadataCatalogueLinkage(repository, lmd,cata); | ||
| return (T)(object)new LoadMetadataCatalogueLinkage(repository, lmd, cata); |
Check warning
Code scanning / CodeQL
Useless upcast Warning
rdteviotdale
approved these changes
Jul 10, 2024
JFriel
added a commit
that referenced
this pull request
Jul 18, 2024
* add cron test * fix yaml * fix yaml * update spacing * use example * update cron * update to push * add 2am cron * update yaml * use utc * add first update * add populate function * add changelog * update tests * fix test * attempt to fix test * interim * interim * add label * add description field * add vertical scaling * working UI * add tooltips * working ui * add to cignorelist * add changelog entry * tidy up * fix typo * fix codeql * Task/rdmp-1 Update Ticketing System (#1870) * add initial ticketing update * fix patch * interim * allow blanks * pass statuses around * update tests * add image * add resources * tidy up * tidy up * fix build * add icon * add image * fix test * add changelog * fix error not poping * add missing line * fix typo * tidy up * Bump ObjectListView.Repack.NET6Plus from 2.9.4 to 2.9.5 Bumps ObjectListView.Repack.NET6Plus from 2.9.4 to 2.9.5. --- updated-dependencies: - dependency-name: ObjectListView.Repack.NET6Plus dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump Terminal.Gui from 1.17.0 to 1.17.1 (#1879) Bumps Terminal.Gui from 1.17.0 to 1.17.1. --- updated-dependencies: - dependency-name: Terminal.Gui dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-dotnet from 4.0.0 to 4.0.1 (#1875) Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4.0.0...v4.0.1) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add read onlu to plugins * update changelog * Bugfix/rdmp 210: Improve LoadMetadata directory checking (#1884) * add folders check * add load directory checks * add changelog * update imports --------- Co-authored-by: James A Sutherland <[email protected]> * Bump HIC.FAnsiSql from 3.2.5 to 3.2.6 (#1886) * Delete directory.build.props (#1887) Remove duplicate file - we have two identical files which differ only in case... * add changelog * Bugfix/rdmp 209 default instance (#1889) * add missing file * add no reopining * Bugfix: Fix overeager PK setting for extraction Identifiers (#1888) * remove ei pk force * update for tests * Bump YamlDotNet from 15.3.0 to 16.0.0 Bumps YamlDotNet from 15.3.0 to 16.0.0. --- updated-dependencies: - dependency-name: YamlDotNet dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update VersionYamlTypeConverter.cs Update for new YamlDotNet API * Update CHANGELOG.md --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Brian <[email protected]> Co-authored-by: rdteviotdale <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James A Sutherland <[email protected]> Co-authored-by: James A Sutherland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Summarise your proposed changes here, including any notes for reviewers.
Type of change
What types of changes does your code introduce? Tick all that apply.
Checklist
By opening this PR, I confirm that I have: