Efficiency enhancements #1829
Efficiency enhancements #1829
Conversation
Eliminate double-searching of CommentStore
Clearer variable type, remove redundant casts
Make callbacks static for simplicity
Join declaration and initialisation
Simplify list generation logic
Remove redundant counting of list size
Avoid thread-thrashing if yes or no to all has been clicked
Fix duplicate Dispose calls
Make fake conditional value a constant
String interpolation, object initialisers
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| foreach (var f in selected) | ||
| using (var stream = File.Open(f.FullName, FileMode.Open)) | ||
| { | ||
| shareManager.ImportSharedObject(stream); | ||
| } | ||
| { | ||
| using var stream = File.Open(f.FullName, FileMode.Open); | ||
| shareManager.ImportSharedObject(stream); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select Note
| foreach (var xml in Directory.EnumerateFiles(location, "*.xml", SearchOption.AllDirectories)) | ||
| using (var content = File.OpenRead(xml)) | ||
| { | ||
| ReadComments(content); | ||
| } | ||
| { | ||
| using var content = File.OpenRead(xml); | ||
| ReadComments(content); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select Note
| foreach (var zipFile in new[] { zipArchive }.Union(SupplementalSourceZipFiles).Where(static zipFile => zipFile.Exists)) | ||
| { | ||
| using var z = ZipFile.OpenRead(zipFile.FullName); | ||
| foreach (var entry in z.Entries) | ||
| entries.Add(entry.Name); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select Note
| @@ -69,7 +69,7 @@ | |||
| return; | |||
| } | |||
|
|
|||
| _alreadyMarkedInConfiguration = _selectedDataSetColumns.Where(c => Getter(c)).ToArray(); | |||
| _alreadyMarkedInConfiguration = _selectedDataSetColumns.Where(Getter).ToArray(); | |||
Check warning
Code scanning / CodeQL
Virtual call in constructor or destructor Warning
| @@ -81,7 +81,7 @@ | |||
| return; | |||
| } | |||
|
|
|||
| _alreadyMarked = _extractionInformations.Where(c => Getter(c)).ToArray(); | |||
| _alreadyMarked = _extractionInformations.Where(Getter).ToArray(); | |||
Check warning
Code scanning / CodeQL
Virtual call in constructor or destructor Warning
| @@ -80,19 +80,18 @@ | |||
| /// <inheritdoc/> | |||
| public override bool Equals(object obj) | |||
| { | |||
| if (obj is QueryTimeColumn == false) | |||
| throw new Exception(".Equals only works for objects of type QueryTimeColumn"); | |||
| if (obj is QueryTimeColumn other) | |||
Check warning
Code scanning / CodeQL
Equals should not apply "is" Warning
Proposed Change
Summarise your proposed changes here, including any notes for reviewers.
Type of change
What types of changes does your code introduce? Tick all that apply.
Checklist
By opening this PR, I confirm that I have: