-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] interval
setting does seem to ignore startAt
#247
Comments
Oh! Will have a look at this as soon as possible. Thanks for a great bug report! |
Hello, @Hexagon, I gave finding the bug a shot, and I think I have fixed it. |
@buzzinJohnnyBoi Awesome, send the PR 👍 |
I sent the PR, wasn't sure if you wanted me to include the changes after running |
@buzzinJohnnyBoi's fix available to test through |
Closing as #248 was merged ^^ |
An additional fix by @buzzinJohnnyBoi released through prerelease |
Describe the bug
Hi, first thanks a ton for the library. We have been (ab)using it a lot.
I think we have come across what I think is a bug in the implementation of #63:
If
startAt
is in the past,interval
does not calculate starting fromstartAt
but is skippped instead (We think).To Reproduce
Steps to reproduce the behavior:
startAt
and an absurdly largeinterval
(to make what I think is a bug more obvious ^^)https://jsfiddle.net/ak85Lwrv/4/
Expected behavior
I would expect that the first execution of the cronjob is not "now" and then the
interval
comes into play, but rather that this respectsstartAt
.System:
Additional context
This issue is the outcome of the investigation of @buzzinJohnnyBoi in louislam/uptime-kuma#4738
The text was updated successfully, but these errors were encountered: