Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in variable name "slo_forwad_on_logout" #40

Closed
protag opened this issue Jan 22, 2020 · 2 comments · Fixed by #42
Closed

Typo in variable name "slo_forwad_on_logout" #40

protag opened this issue Jan 22, 2020 · 2 comments · Fixed by #42
Labels
good first issue Good for newcomers

Comments

@protag
Copy link

protag commented Jan 22, 2020

In the README.md, it says:

The SAMLAuthenticator usually attempts to forward users to the SLO URI set in the SAML Metadata. If this is not the desired behavior for whatever reason, set slo_forward_on_logout to False. This will change the page the user is forwarded to on logout from the page specified in the xml metadata to the standard jupyterhub logout page.

However, the example config in the README and the code itself uses the variable name "slo_forwad_on_logout".
@distortedsignal
Copy link
Contributor

Wow, can't believe that I screwed that up.

@distortedsignal distortedsignal added the good first issue Good for newcomers label Jan 23, 2020
@distortedsignal
Copy link
Contributor

I think I would prefer that this be taken on in a non-breaking way - no reason to cause current configs to become invalid - but to prefer the proper spelling.

@duongnt duongnt mentioned this issue Feb 20, 2020
Merged
@jeffmaley jeffmaley mentioned this issue Sep 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix minor typo
2 participants
@distortedsignal @protag