-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add PacketRusher version as tags #77
Comments
Hi @Borjis131, Thanks! |
Thank you, great work @linouxis9! |
Hello @linouxis9, I saw that the current PacketRusher version is 1.0.1. So it seems that the release is more or less official now? I reach to you because I had a problem using the Docker version that is difficult to solve without having the version as tags. The Docker container needs the gtp5g module installed on the host machine and the Docker version of PacketRusher was using a different compiled version of PacketRusher. So without having the same version on both places, is difficult to check if the versions match or not. So, please, if the release is official, consider adding the version as a tag and a release. If not, just keep working, you are already doing a great job! |
Hi @Borjis131! I understand your concern and issue! As such, I've created a tag 20240521: https://github.com/HewlettPackard/PacketRusher/releases/tag/20240521 Does it solve your issue for the time being? Sadly, PacketRusher is not yet ready for a v1.0.0, and I would like for PacketRusher to respect semver principles, so I would like to avoid to release a v1.0.0 for now, and considering the continuous developement cycle (each commit is usually better than the previous one and fix some issues), I feel releasing from time to time v0.a.b do not make too much sense -> main is always the version to use. Actually, PacketRusher has reported itself as being v1.0.1 since its open source release. Thanks a lot for using PacketRusher, I hope I can help you :-)! Valentin |
Hi @linouxis9, sorry I did not check the version reported by PacketRusher previously and I thought it was something new. There is no need to create a tag each commit, so no rush, as soon as you start publishing the tags using semantic versioning, I will update the docker project. Thanks you! |
As the project continues to grow and more features are added, it would be useful to have the possibility to clone specific versions of this software. Adding tags to specific versions could facilitate users to clone this versions.
Also this tags can be setup along with the Releases.
The text was updated successfully, but these errors were encountered: