Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not to use string instead of int? #124

Open
brianchennn opened this issue May 3, 2024 · 1 comment
Open

Why not to use string instead of int? #124

brianchennn opened this issue May 3, 2024 · 1 comment

Comments

@brianchennn
Copy link
Contributor

Sst int `yaml:"sst"`

I tried to use helm chart to deploy Packet Rusher to Kubernetes Cluster. The type of gnodeb.slicesupportlist.sst in config.yml is string while ue.snssai.sst is integer. This make entrypoint.sh hard to replace ENV variable to integer, can you modify the type to string?

image
image

@linouxis9
Copy link
Member

Hi @brianchennn,

I think the rationale to use int instead of string was to enforce that SST was mandatory while SD was not. Though it's stupid (especially since slicesupportlist and snssai should have the same format), and we need a proper configuration validator instead.
We indeed need to fix that!
By the way, you may also want to take a look at Gradiant's PacketRusher Helm Chart which does not use our entrypoint and instead just generate a config.yml out of a template: https://github.com/Gradiant/5g-charts/tree/main/charts/packetrusher

Cheers,
Valentin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants