From 227cbb0bdd6a50163ad9d041a544b5d866280c0c Mon Sep 17 00:00:00 2001 From: Quinton Miller Date: Fri, 10 Nov 2023 05:44:14 +0800 Subject: [PATCH] fixup --- src/compiler/crystal/codegen/target.cr | 2 +- src/llvm/jit_compiler.cr | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/crystal/codegen/target.cr b/src/compiler/crystal/codegen/target.cr index 1e731d801b58..8817221c18b9 100644 --- a/src/compiler/crystal/codegen/target.cr +++ b/src/compiler/crystal/codegen/target.cr @@ -195,7 +195,7 @@ class Crystal::Codegen::Target target = LLVM::Target.from_triple(self.to_s) machine = target.create_target_machine(self.to_s, cpu: cpu, features: features, opt_level: opt_level, code_model: code_model).not_nil! - # We need to disable global isel until https://reviews.llvm.org/D80898 is released, + # FIXME: We need to disable global isel until https://reviews.llvm.org/D80898 is released, # or we fixed generating values for 0 sized types. # When removing this, also remove it from the ABI specs and jit compiler. # See https://github.com/crystal-lang/crystal/issues/9297#issuecomment-636512270 diff --git a/src/llvm/jit_compiler.cr b/src/llvm/jit_compiler.cr index f307ffc55c58..3481212e1b93 100644 --- a/src/llvm/jit_compiler.cr +++ b/src/llvm/jit_compiler.cr @@ -9,7 +9,7 @@ class LLVM::JITCompiler raise LLVM.string_and_dispose(error) end - # We need to disable global isel until https://reviews.llvm.org/D80898 is released, + # FIXME: We need to disable global isel until https://reviews.llvm.org/D80898 is released, # or we fixed generating values for 0 sized types. # When removing this, also remove it from the ABI specs and Crystal::Codegen::Target. # See https://github.com/crystal-lang/crystal/issues/9297#issuecomment-636512270