Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "XCURSOR_PATH" environment variable to the Flatpak manifest by default #3624

Closed
severtheskyline opened this issue Mar 12, 2024 · 6 comments
Labels
feature-request New feature needs to be implemented.

Comments

@severtheskyline
Copy link

Problem description

When running Heroic natively in Wayland using the Flatpak version, the cursor looks completely different than your desktop/theme's cursor, this doesn't happen when the app runs natively on Wayland in a native environment (like installed via the AUR on Arch) or when running on Xwayland both on the flatpak and native versions. It looks something like this:

https://youtu.be/33kftEOxXbQ
(I wanted to upload on github directly, but I guess they can't fathom the idea of a 19 mb video file. And don't worry, the 2007 xbox 360 gameplay quality goes away in a couple of seconds.)

Feature description

However, when adding "XCURSOR_PATH=/run/host/user-share/icons:/run/host/share/icons" as an environment variable in the flatpak manifest, now it can properly see the cursor your desktop/theme uses. This is also used in Vesktop which fixes the same issue, and should fix #3236 since it seems to fix the issue when overriding it in the command line. It should look something like this:

https://youtu.be/nPGYLBirwIk
(Same story as before)

Alternatives

In the mentioned #3236, it was mentioned that this was a Chromium specific issue and that Heroic couldn't really fix it, so I'm not sure if this counts as a hacky fix and if a proper Chromium fix is needed/wanted, however, it seemed that this fixes the same issue on Vesktop, so I'm not sure how "hacky" this could be.

Additional information

Not much other than technical details I may or may not fully understand about the flatpak sandbox (?

@severtheskyline severtheskyline added the feature-request New feature needs to be implemented. label Mar 12, 2024
@JakobDev
Copy link
Contributor

Electron supports the cursor shape protocol since version 29. This Wayland protocol is supported by every major compositor except Gnome, so upgrading Electron should fix the Problem.

@severtheskyline
Copy link
Author

This Wayland protocol is supported by every major compositor except Gnome

So tipical ain't it

Anyway, is Heroic stuck in a specific electron/chromium version?

@JakobDev
Copy link
Contributor

So tipical ain't it

Update: Gnome is finally working on it, although I have a bad feeling about the Not even sure if we really want this sentence.

Anyway, is Heroic stuck in a specific electron/chromium version?

Yes, as all Electron programs, but they are working on updating Electron.

@severtheskyline
Copy link
Author

If I attempt for markdown more my computer will explode- Yeah, sorry about that first comment.

And for that second one, I guess it could be added for the time being, if anything for compositors that doesn't implement it when it is generally adopted by Electron apps and other compositors.

@dariox86
Copy link

This is fixed for me in the latest version. I am on GNOME Wayland. I have «ELECTRON_OZONE_PLATFORM_HINT=wayland» environment variable.

@Etaash-mathamsetty
Copy link
Member

Closing, since we use Electron 31 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature needs to be implemented.
Projects
None yet
Development

No branches or pull requests

4 participants