Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackview with Autolayout Issues #19

Closed
felix-dumit opened this issue Jan 6, 2017 · 3 comments
Closed

Stackview with Autolayout Issues #19

felix-dumit opened this issue Jan 6, 2017 · 3 comments

Comments

@felix-dumit
Copy link

Probably related to #14

I updated the basic example to use StackViews and had a few issues:

  1. I had to set the autolayout priority to 999 for the height constraint in a horizontal stackview and for the width constraint in a vertical stackview, otherwise, it would complain about an ambiguous layout.

  2. The animations still look a bit off, you can see from the image below, in the 1st animation, all labels jump after the screen initially loads. The 2nd animation just doesn't look right.

HELLO

I have the code I used up here:
https://github.com/felix-dumit/Hero/tree/stackview-autolayout

Thanks for this lib I think it's really awesome!

@lkzhao
Copy link
Collaborator

lkzhao commented Jan 7, 2017

@felix-dumit
Thanks for such a detailed report.

I put up a fix. Can you rebase your example to branch stack-view-fix-2 and check if it actually fixes it?

@felix-dumit
Copy link
Author

@lkzhao Yes it's working fine now! 👍

I haven't tested yet on the project I was trying to integrate, where I first noticed the issue.
I also had an issue with a UIVisualEffectView getting broken and just displaying a black background.
I'll give that another test and in case it's still happening I'll try to give you a simple reproducible example.

@lkzhao
Copy link
Collaborator

lkzhao commented Jan 7, 2017

Oh that, UIVisualEffectView has always been problematic. 🤦🏻‍♂️ No easy way to snapshot them and maintain the effect live.
Help me open up another issue. I will see what I can do.

@lkzhao lkzhao closed this as completed Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants