Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment language #137

Open
cnmicha opened this issue Mar 11, 2017 · 10 comments
Open

comment language #137

cnmicha opened this issue Mar 11, 2017 · 10 comments

Comments

@cnmicha
Copy link
Member

cnmicha commented Mar 11, 2017

No description provided.

@JanMich
Copy link
Contributor

JanMich commented Mar 14, 2017

why? this should be understandable by everyone!

@cnmicha cnmicha changed the title write comments in english comment language Mar 14, 2017
@PSchlesselmann
Copy link
Contributor

Well, everyone should be able to understand english.

@bvorak
Copy link
Contributor

bvorak commented Mar 14, 2017

I feel like it would make more sense to have consistent (English) code comments than to lead discussions like this one in English...:P
But if you really feel uncomfortable about English comments leave them German for now I'd say...translating them isn't necessarily the most important thing at the moment.
But we should ensure that the content and style is somewhat consistent across units.

@PSchlesselmann
Copy link
Contributor

Yeah, in case you are not familiar enough with this language: Just keep your comments in german.
We will translate them later.

@frcroth
Copy link
Contributor

frcroth commented Mar 17, 2017

The GUI doesn't even have comments...

@ghost
Copy link

ghost commented Mar 18, 2017

In my opinion comments in english are not useful because it is for your school that will alway be german and why should we run danger that there are misconceptions because of the language.
Ok it looks professional but for example a software developer would never write instructions in english when he has an german customer.
We should guarentee that everyone understand our instructions and we could not if we write our comments in english. Also we should estimate the time users have to spend by look up words they don`t know.

@bvorak
Copy link
Contributor

bvorak commented Mar 18, 2017

And we also need to remember that right now we are mainly coding for Kraxeleddi ^^

@PSchlesselmann
Copy link
Contributor

Well how about just asking him about his preference?
Then we can be sure and this discussion finally becomes unnecessary.

@PSchlesselmann
Copy link
Contributor

I asked him: He prefers german.

@ghost ghost removed the management label Mar 21, 2017
@bvorak
Copy link
Contributor

bvorak commented Mar 21, 2017

So we should probably translate all of our commments to German then I guess...maybe it's not a must until Friday though if we have a good Documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants