Roof orientation quest is asked on demolished:building

[rusty-snake]

How to Reproduce

Expected Behavior
No building related quests on

demolished:building=*

building:levels=*
roof:levels=*
roof:shape=gabled

Does it happen in normal StreetComplete?
No

Versions affected
SCEE 60.2

[mcliquid]

@FloEdelmann Wouldn't it be the easiest just to check additionally whether it is a building at this point, instead of excluding all life cycle prefixes? Or am I thinking too short here?

SCEE/app/src/main/java/de/westnordost/streetcomplete/quests/roof_orientation/AddRoofOrientation.kt

Line 25 in d4f3feb

and building !~ no|construction

E.g.:
and building and building !~ no|construction

[mnalis]

and building and building !~ no|construction

• yes, that suggestion sound like correct check which was probably intended, as it would silently skip a quest unless building tag is defined.

• However, the tagging is broken in the mentioned example (if it is demolished:building, it surely cannot have roof:levels etc), so the quest being presented is actually an opportunity to leave a note, so data can be properly fixed.

So I'm undecided which is better.

I personally usually prefer correct data (so leaving a note), but on the other hand, incorrect data is of low usability here, so just skipping the quest and not bothering the SCEE mapper might be better?

[mcliquid]

However, the tagging is broken in the mentioned example (if it is demolished:building, it surely cannot have roof:levels etc), so the quest being presented is actually an opportunity to leave a note, so data can be properly fixed.

Let's assume there is an object with the following tags:

building=yes
roof:shape=gabled
roof:levels=1
building:levels=2

Then you open SCEE, the building quest is displayed and you select "Does not exist" and then "It is demolished". Then demolished: is set, but none of the other tags are deleted. Conclusion: SCEE produces this incorrect tagging itself.

[mnalis]

Then you open SCEE, the building quest is displayed and you select "Does not exist" and then "It is demolished". Then demolished: is set, but none of the other tags are deleted. Conclusion: SCEE produces this incorrect tagging itself.

Yes, I agree... SCEE handling here is not ideal.

SC(EE) has curated list of tags that should be removed when shop/amenity is marked as vacant.

To properly fix the broken tagging that you describe, ideally someone would need to curate a similar list of tags, but for demolished buildings instead. That is probably too much work (so I don't volunteer this time)... 😿

But at least, SCEE should remove roof:* and building:* tags when it marks a building as demolished, in addition to prepending demolished: prefix to that building=* tag, as all of them are most probably no longer correct. Would you agree? (I can probably do PR to improve that, unless you'd like to @mcliquid ? or someone else of course!)

---

That is however orthogonal issue to this particular problem; which is: how to handle such existing conflicting tagging (regardless whether it was introduced by SCEE or some other editor).

[biketeur]

Unabhängig von diesem speziellen Fall:
Wie erreiche ich überhaupt, dass SCEE nach der Dachorientierung fragt?
Ich finde keinen Schalter hierfür.

[rusty-snake]

Einstellungen > Quests > Welche grundlegende Dachform hat dieses Gebäude?

Ab SCEE 60.2

[FloEdelmann]

@rusty-snake Das ist ein anderer Quest. Der neue Quest heißt auf deutsch „Wie ist der Dachfirst ausgerichtet?“

[rusty-snake]

Ups, stimmt. Hab ich wohl den falschen Text abgetippt.

[FloEdelmann]

• AddRoofShape (native SC quest) has building and building !~ no|construction
• AddRoofColour and AddRoofOrientation (SCEE-only quests) both have building !~ no|construction

So I agree that adding a check for building for both would make sense.

[biketeur]

Nach wie vor:
ich finde keine Quest „Wie ist der Dachfirst ausgerichtet“ in den 223 Aufgaben-Auswahlen .

[HolgerJeromin]

v60.2 has 225 quests :)

https://github.com/Helium314/SCEE/releases/tag/v60.2