Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes created by me not showing #747

Open
meiphoo7-Mae opened this issue Mar 5, 2025 · 6 comments
Open

Notes created by me not showing #747

meiphoo7-Mae opened this issue Mar 5, 2025 · 6 comments
Labels
bug Something isn't working question Further information is requested

Comments

@meiphoo7-Mae
Copy link

Using the brand new notes functionality added in 60.2 I expected to be able to see my own notes that I attached to objects to appear on the map.
Apparently they don't because I don't see any markers. When I go to an object of which I know that I have attached a note to it and click on it then I get a message stating:
"Another person noted:" followed by the text of my own note. But this worked before even without the new functionality. So to actually find notes still requires trial and error.
Unfortunately I can't test it in general because in my mapping area there are no notes created by other users.

So apparently:

  1. Even with all relevant switches activated no markers of notes are shown (or my expectations are too high...)
  2. The app doesn't even recognize notes created by me because it claims that: "Another person noted:".

How to Reproduce

  • Activate: Settings > Show all notes
  • Activate: Settings > Notes > "Show all notes" means ALL notes

Expected Behavior

Markers indicating notes created by me should become visible

Does it happen in normal StreetComplete?

No, normal StreetComplete doesn't have this function.

Versions affected

60.2 on Android 10.

Additional suggestion:
It might be a plan to take a look at other similar open source projects.
Organic Maps has a great bookmark system to put a private marker on any random position on the map and attach a private note to it.

@meiphoo7-Mae meiphoo7-Mae added the bug Something isn't working label Mar 5, 2025
@mnalis
Copy link
Collaborator

mnalis commented Mar 6, 2025

Activate: Settings > Notes > "Show all notes" means ALL notes

If (after changing those settings) you fully exit the SCEE and remove it from Android list of recent apps (i.e. swiping it up), and then start SCEE again, does the new setting take effect?

If it starts working correctly after that, then it is (unfortunately) known limitation, see SCEE FAQ: Some settings don't seem to change the behaviour

@meiphoo7-Mae
Copy link
Author

No, I know about that limitation. For me it's really not working, not even after a reboot of my phone.

After some thinking I assumed it could be a problem related to the new map generating technology introduced in v59 that appears to decide on its own to hide things (even names of streets) when it is overcrowded with data, which problem I reported at SC months ago but what was more or less deemed as not important enough (or to put it differently: an upstream decision to do it like this).
But interestingly: No, that isn't the case. Even if I use settings that generate an almost empty map (so no competing quests) I don't see any of my notes.
That's still not a full blown test, but as I noted before there are no notes created by other users in my mapping area.

@mnalis
Copy link
Collaborator

mnalis commented Mar 6, 2025

No, I know about that limitation. For me it's really not working, not even after a reboot of my phone.

Interesting. Can you provide exact step-by-step instructions what are you pressing and which options are you choosing (and maybe elements) on which you see the problem, so I can try to reproduce?
Or even better if you can produce a screencast video?

This screencast video show how it works for me (with both settings enabled):

Video (click to expand)
small_Screen_Recording_20250306_184807_SCEE.mp4

As you can see, even notes newly created by me, or commented on by me (even on my own notes) remains shown on the map. Only if I explicitly click to hide the note, does it get removed from the map. Does doing the exactly the same steps as I did in that video work for you? Or it behaves differently? Or maybe you are trying some different thing (GPX waypoint instead of OSM Note for example) ?

@meiphoo7-Mae
Copy link
Author

Hmm, I believe I know what's up here.
Can you repeat this and this time attach a note to a building or a road or something else that is not characterized as being a "thing"?

@mnalis
Copy link
Collaborator

mnalis commented Mar 7, 2025

Buildings and ways also work for me (of course if it was a long road or huge building, the note could be attached some places away on the center/centroid of that way/building) .

small_Screen_Recording_20250307_044157_SCEE.mp4

Could you share a video where it doesn't work for you @meiphoo7-Mae ?

@mnalis mnalis added the question Further information is requested label Mar 8, 2025
@mnalis
Copy link
Collaborator

mnalis commented Mar 8, 2025

And just to make sure: you do have "Can you contribute anything to this note?" quest enabled in your current preset, yes?

If so, video of what you're doing would be very helpful. Currently I can not reproduce the problem. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants