Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background type switch gone #629

Open
RubenKelevra opened this issue Aug 31, 2024 · 7 comments
Open

background type switch gone #629

RubenKelevra opened this issue Aug 31, 2024 · 7 comments
Labels
bug Something isn't working PR welcome Needs someone to implement it

Comments

@RubenKelevra
Copy link

Maybe I'm overlooking something, but is the background type switch now gone?

How to Reproduce
Open settings

Expected Behavior
Have a background switch, like before

Does it happen in normal StreetComplete?
Nope, SC doesn't have the feature

Versions affected
Android 12
SCEE Version 58.22

@RubenKelevra RubenKelevra added the bug Something isn't working label Aug 31, 2024
@pkoby
Copy link

pkoby commented Sep 2, 2024

I have v59.0-alpha2, but if you're looking for the toggle for aerial/map background, in Settings, turn on Expert mode, click UI, then turn on Quick Settings Button. The cog button then has the background switcher.

@mnalis
Copy link
Collaborator

mnalis commented Sep 5, 2024

click UI, then turn on Quick Settings Button. The cog button then has the background switcher.

Works for me in SCEE 58.22 (on Android 6.0.1) too 👍 (and expert mode is not even needed).

@Helium314
Copy link
Owner

The switch was part of SC, and wasn't re-added when the settings were migrated to compose

@Helium314 Helium314 added the PR welcome Needs someone to implement it label Sep 6, 2024
@RubenKelevra
Copy link
Author

The switch was part of SC, and wasn't re-added when the settings were migrated to compose

Why not readd a drop-down under Display in the settings, to keep it consistent?

There's no indication of this change in the changelog, right? So I wasn't expecting that the feature of having aerials is just "gone".

@Helium314
Copy link
Owner

Changelog is only for SCEE, and I will not start listing SC changes in there even if the affect SCEE in different / unintended ways

Why not readd a drop-down under Display in the settings, to keep it consistent?

I don't think a drop-down would be consistent for an essentialy boolean setting, but I don't care enough to demand changes if a setting was added like this in a PR.

@mnalis
Copy link
Collaborator

mnalis commented Sep 8, 2024

I don't think a drop-down would be consistent for an essentialy boolean setting

@RubenKelevra
Copy link
Author

I don't think a drop-down would be consistent for an essentialy boolean setting

I would love to add the Aerials released for OSM use by my state. They are like 10 times better resolution than Esri and well aligned with GPS positions.

But it's always good to be able to switch back and forth, as some aerials are better than others for some areas.

A good example for this is tree positions which are easier to spot on winter images, where trees cast long shadows and have nearly no leaves.

Maybe allow for custom entries to be added and just shown in the list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR welcome Needs someone to implement it
Projects
None yet
Development

No branches or pull requests

4 participants