Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

DBT can be used to find "solution" PRs in addtion to "culprit" PRs. #24

Open
Ebola16 opened this issue Oct 15, 2017 · 2 comments
Open

Comments

@Ebola16
Copy link

Ebola16 commented Oct 15, 2017

DBT is currently worded to find "culprit" PRs, where a problem is introduced. Sometimes it is necessary to find "Solution" PRs that solve a problem too.

Perhaps a new menu could be added?
The PR in question:

  • Introduces a problem
  • Solves a problem

If "Solves a problem" is selected, swap the "Select a development build that is broken" and "Select a development build that worked" labels. "GOOD" and "BAD" would need to be swapped in the log. And the message that identifies the "culprit" PR when finished should probably be changed to "solution."

@Helios747
Copy link
Owner

Meh. My tool was designed to find problem builds. And that's what most users use it for. It's also trivial for users to look at the build and say "ok the next/previous build fixes this".

Not really interested myself in implementing that. If somebody else makes a PR, I'll consider merging, but this just seems like a request for an option to change some wording and change whether DBT +1s or -1s the final result. Meh.

@Ebola16
Copy link
Author

Ebola16 commented Oct 16, 2017

If I'm currently looking for a PR that solves a problem using DBT, I treat the solution as a problem. For bisects with a large number of trials and complicated reproduction instructions it can be a pain to remember to invert my findings with DBT.

I agree that my proposed changes aren't essential, but I would certainly welcome them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants