Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on docs #2947

Open
DarkNeedle opened this issue Nov 9, 2024 · 0 comments
Open

Issue on docs #2947

DarkNeedle opened this issue Nov 9, 2024 · 0 comments

Comments

@DarkNeedle
Copy link

Path: /getting-started/self-host/docker

There are a number of corrections that need to be made. Assuming everyone is up to date on their Docker install.

1.docker build --platform linux/amd64 -t helicone/supabase-migration-runner -f dockerfiles/dockerfile_migration_runner .
Should be
docker build --platform linux/amd64 -t helicone/supabase-migration-runner -f dockerfiles/dockerfile_supabase_migration_runner .
Reason: No such Dockerfile exist in the docker/dockerfiles folder

  1. Remove the --platform directive, it is unnecessary. Only necessary when the specific target is needed for deployment

  2. In the docker/dockerfiles/dockerfile_supabase_migration_runner file, remove the platform directive, no longer used, incorrect usage.

  3. The workers do not build without errors on clean install

  4. README.md in docker needs to be updated to reflect these changes as do the docs

Recommend someone performa a manual fresh install on a clean VM and test these files to be sure they are working. All too often developers have libraries or tools in their existing environment, many not up to date.

Seem to be 4 version behind on node with many packages deprecated as well. Suggest as part of maintaining a secure product understand the need to keep packages and node version at "n" or max "n-1"

DN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant