Add in-play golden frames #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andburn
commented
Sep 13, 2016
andburn
commented
- Adds images for golden in-play minions
- Adds class colours to golden cards (uses css filters so the colours aren't 100% correct, but better than 30 extra images).
|
Thanks, looking very good. Will fully review and land later this week. |
beheh
requested changes
Sep 15, 2016
| @@ -20,10 +20,15 @@ class InPlayCardArt extends React.Component<EntityProps, {}> { | |||
| var images = []; | |||
| var entity = this.props.entity; | |||
| var controller = this.props.controller; | |||
| var postfix = ""; | |||
| if (entity.isPremium()) { | ||
| images.push({ | ||
| image: premiumOverlay, | ||
| classes: ["inhand-base", premiumOverlayClass] |
There was a problem hiding this comment.
Add trailing comma, please.
| @@ -18,6 +18,9 @@ class InHandCardArt extends React.Component<InHandCardArtProps, {}> { | |||
| var entity = this.props.entity; | |||
| var portraitClass = null; | |||
| var frame = null; | |||
| var premiumOverlay = null; | |||
| var premiumOverlayClass = null; | |||
| var cardClass = this.cardClassToString(); | |||
There was a problem hiding this comment.
Use let instead of var for all.
| } | ||
|
|
||
| .shaman-color { | ||
| filter: hue-rotate(250deg) saturate(75%) brightness(80%); |
There was a problem hiding this comment.
Color looks wrong, looks right for me with about filter: hue-rotate(220deg) saturate(50%) brightness(100%);
beheh
reviewed
Sep 15, 2016
| } | ||
|
|
||
| .mage-color { | ||
| filter: hue-rotate(303deg) saturate(88%) brightness(94%); |
|
Updated. Did my best with improving the colours, paladin is completely wrong though - I just can't seem to get anything close to the colour. They look like this now:
|
beheh
force-pushed
the
master
branch
2 times, most recently
from
22af358 to
8fe2b38
Compare
beheh
approved these changes
Sep 18, 2016
|
👍 Nice work. Landing this and revisiting the paladin color in #139. |
Uses an image for each card type and applies css filters to approximate the class color.
|
Mage is also really broken, following up in #139. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.