Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log style callbacks to also work in release mode #3273

Closed
Vortex2Oblivion opened this issue Oct 26, 2024 · 3 comments · Fixed by #3307
Closed

Change log style callbacks to also work in release mode #3273

Vortex2Oblivion opened this issue Oct 26, 2024 · 3 comments · Fixed by #3307

Comments

@Vortex2Oblivion
Copy link
Contributor

If you wanted to detect when a log from the flixel debugger would be detected in release mode, like I do, there is currently no way to do this due to log style callbacks not being run in release mode.
In order to do this I had to extend LogFrontEnd and then replace the LogFrontEnd in FlxG with the untyped keyword due to it being unable to be written to normally.

@Vortex2Oblivion
Copy link
Contributor Author

image
also when trying to get the data from a log style there is a high chance that it will just crash with no error or give an error like this from what ive seen

@Geokureli
Copy link
Member

At first i was gonna say this is a breaking change, in case someone depended on callback being used in debug only, but we depercated callbackFunction and added callback in 5.9.0 which is still unreleased. This means we can have callback work on debug, but not callbackFunction

@Vortex2Oblivion
Copy link
Contributor Author

image

also when trying to get the data from a log style there is a high chance that it will just crash with no error or give an error like this from what ive seen

For anyone wondering why this was crashing it was because I was running it on a thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants