Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile issue on FlxSound. #2677

Closed
MAJigsaw77 opened this issue Nov 20, 2022 · 19 comments · Fixed by #2678
Closed

Compile issue on FlxSound. #2677

MAJigsaw77 opened this issue Nov 20, 2022 · 19 comments · Fixed by #2678

Comments

@MAJigsaw77
Copy link
Contributor

If i use a older version of Lime, this happens /opt/hostedtoolcache/haxe/4.2.5/x64/lib/flixel/5,0,0/flixel/system/FlxSound.hx:753: characters 23-28 : lime.media.AudioSource has no field pitch

@Geokureli
Copy link
Member

Geokureli commented Nov 20, 2022

@Cheemsandfriends would you be able to check this feature with lime 7, this isn't the only issue we've seen in this area. I recently fixed a compile issue that was reported in FlxDefines, as well: ce45308

@MAJigsaw77 try compiling with -DFLX_NO_PITCH or add <haxedef name="FLX_NO_PITCH" /> to your project.xml

@MAJigsaw77
Copy link
Contributor Author

Ok

@Geokureli
Copy link
Member

@MAJigsaw77 what target are you building to and what lime version are you using?

@MAJigsaw77
Copy link
Contributor Author

I'm using Lime 7.9.0 and I'm building android

@MAJigsaw77
Copy link
Contributor Author

Also, the define worked.

@MAJigsaw77
Copy link
Contributor Author

I'm using Lime 7.9.0 and I'm building android

8.0.0 has some issues

@MAJigsaw77
Copy link
Contributor Author

That's why

@Geokureli
Copy link
Member

Geokureli commented Nov 20, 2022

what issues? just curious

@MAJigsaw77
Copy link
Contributor Author

MAJigsaw77 commented Nov 20, 2022

Svg icons have higher priority and this issue shows only on android.

@MAJigsaw77
Copy link
Contributor Author

MAJigsaw77 commented Nov 20, 2022

JNI in macro context crashes the compile.

@MAJigsaw77
Copy link
Contributor Author

JNI in macro context crashes the compile.

If i use fields

@MAJigsaw77
Copy link
Contributor Author

This issue won't get fixed until the next release?

@MAJigsaw77
Copy link
Contributor Author

@Geokureli

@Geokureli
Copy link
Member

Geokureli commented Nov 20, 2022

This issue won't get fixed until the next release?

Yes

Btw you can edit messages here instead of sending 5 amending messages. It'll even update it as I'm reading it

@Cheemsandfriends
Copy link
Contributor

Cheemsandfriends commented Nov 20, 2022

@Geokureli the line that is giving issues is basically where the pitch is set.
I don't understand how os it giving errors since the functions (both get and set pitch) are wrapped in the target conditional FLX_PITCH
Unless that lime 8 for some reason removed the pitch, I can't explain how is it crashing.
Maybe I'm missing out something.

@Geokureli
Copy link
Member

@Cheemsandfriends MAJigsaw77 is using 7.9.0, the problem is that lime 7.9.0 does not define a pitch property in Audiosource:
https://lib.haxe.org/p/lime/7.9.0/files/src/lime/media/AudioSource.hx

pitch was introduced in lime 8
https://lib.haxe.org/p/lime/8.0.0/files/src/lime/media/AudioSource.hx

@Cheemsandfriends
Copy link
Contributor

Cheemsandfriends commented Nov 20, 2022

@Geokureli Ik that it was introduced in lime 8, I just didn't understand for a second why it defined to FLX_PITCH if it was on lower versions
Now i think that this fixes it?
Sorry for my poor code 😅 I didn't notice that till now

@Geokureli
Copy link
Member

@MAJigsaw77 gonna release a patch sometime early tomorrow

@MAJigsaw77
Copy link
Contributor Author

@MAJigsaw77 gonna release a patch sometime early tomorrow

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants