Support for blend modes with drawQuads, closes #2196 #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shader valid colorMultipliers
JoeCreates
force-pushed
the
BlendModes
branch
from
78744ee to
9af59f8
Compare
JoeCreates
changed the title
Gama11
reviewed
Dec 7, 2018
Gama11
reviewed
Dec 7, 2018
| @@ -493,6 +493,7 @@ class FlxCamera extends FlxBasic | |||
| itemToReturn.colored = colored; | |||
| itemToReturn.hasColorOffsets = hasColorOffsets; | |||
| itemToReturn.blending = blendInt; | |||
| itemToReturn.blend = blend; | |||
There was a problem hiding this comment.
Don't we also need to check blend earlier in this function (lines 468-474) to check if two draw items are the same?
davidetan
added a commit
to davidetan/flixel
that referenced
this pull request
Jul 11, 2024
davidetan
added a commit
to davidetan/flixel
that referenced
this pull request
Jul 11, 2024
davidetan
added a commit
to davidetan/flixel
that referenced
this pull request
Jul 11, 2024
Geokureli
pushed a commit
that referenced
this pull request
Jul 12, 2024
richTrash21
pushed a commit
to richTrash21/flixel-rich
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main bulk of the stuff required for this already got merged into openfl, but one of Joshua's tweaks stopped it working again, so this PR will only have the desired effect once openfl/openfl#2093 gets merged into openfl (but it will build fine with the current develop branch).
Something not so clean in this PR right now is the fact that
BaseDrawItemalready has ablending:Intfor tilesheets, but for the new graphics api we need to pass an actualBlendMode. We don't want to be converting this blend mode to anIntjust to convert it back again (and I'm not sure the ints are even the same as those from Tilesheet).I've added another field,
blend:BlendModetoFlxBaseDrawItem. I feel like the tilesheet stuff should be updated to use this and only convert to an int before it is needed (if there is a need to keep that stuff at all), but that is a bit beyond the scope of this issue.