FlxFramesCollection: check and trim frame sizes, closes #1937 #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i'm not sure whether we should add this check
Gama11
reviewed
Sep 30, 2016
| * @param name optional frame name for debugging info. | ||
| * @return checked and trimmed frame rectangle. | ||
| */ | ||
| private inline function checkFrame(frame:FlxRect, ?name:String):FlxRect |
There was a problem hiding this comment.
I don't think this function is a good inline candidate - too long.
What's the pros / cons? |
|
con: it complicates code. |
|
I think it's nice to have consistent cross-platform behavior, even if the input values are technically incorrect. |
Gama11
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i'm not sure whether we should add this check