fixed -DhscriptPos support in ConsoleUtil.hx #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With hscript version >= 2.0.5 compiling with -DhscriptPos gives compilation error: flixel/4,0,1/flixel/system/debug/console/ConsoleUtil.hx:156: characters 9-42 : Class<hscript.Error> has no field EInvalidAccess The proposed fix uses the error() method now defined in hscript's Interp class (following usage in hscript's Interp.hx)
|
Thanks! |
Aurel300
pushed a commit
to larsiusprime/haxeflixel
that referenced
this pull request
Apr 18, 2018
With hscript version >= 2.0.5 compiling with -DhscriptPos gives compilation error: flixel/4,0,1/flixel/system/debug/console/ConsoleUtil.hx:156: characters 9-42 : Class<hscript.Error> has no field EInvalidAccess The proposed fix uses the error() method now defined in hscript's Interp class (following usage in hscript's Interp.hx)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With:
haxeflixel version 4.0.1
hscript version >= 2.0.5
...compiling on Neko at least with -DhscriptPos gives compilation error:
flixel/4,0,1/flixel/system/debug/console/ConsoleUtil.hx:156: characters 9-42 : Class<hscript.Error> has no field EInvalidAccess
The proposed fix uses the error() method now defined in hscript's Interp class (following usage in hscript's Interp.hx)