Add FlxPointer as a base class for FlxTouch and FlxMouse, closes #1088 #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't like the name of this class, having numbers in class names is just weird. Couldn't we name it |
|
FlxPointer works for me. |
| @@ -44,6 +44,7 @@ class FlxTypedGroup<T:FlxBasic> extends FlxBasic | |||
| @:allow(flixel.FlxObject) | |||
| @:allow(flixel.tile.FlxTilemap) | |||
| @:allow(flixel.system.FlxQuadTree) | |||
| @:allow(flixel.input.FlxPointer) | |||
| private static inline function resolveGroup(ObjectOrGroup:FlxBasic):FlxTypedGroup<FlxBasic> | |||
There was a problem hiding this comment.
Can we move these private static functions to the bottom of the class? I always prefer to list public fields / methods before privates.
There was a problem hiding this comment.
I thought we agreed on putting static fields to the top?
There was a problem hiding this comment.
I don't think private fields should go above public fields, static or not.
There was a problem hiding this comment.
Imo, order should be:
public static
public
private static
private
Gama11
changed the title
Gama11
added a commit
that referenced
this pull request
May 18, 2014
Add FlxPointer as a base class for FlxTouch and FlxMouse, closes #1088
Gama11
added a commit
to HaxeFlixel/flixel-demos
that referenced
this pull request
May 18, 2014
Gama11
added a commit
to HaxeFlixel/flixel-ui
that referenced
this pull request
May 18, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.