FlxAssets.cacheSounds() -> FlxG.sound.cacheAll(), closes #1055 #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -138,6 +138,36 @@ class SoundFrontEnd | |||
| return Assets.getSound(EmbeddedSound, true); | |||
| } | |||
|
|
|||
| #if !doc | |||
| /** | |||
| * Calls FlxG.sound.cache() on all sounds that are embedded. | |||
There was a problem hiding this comment.
This comment needs a warning indicating caching all sounds can lead to high memory usage.
There was a problem hiding this comment.
That should be pretty obvious, but sure, I can add that.
|
Added a warning. |
|
👍 |
gamedevsam
added a commit
that referenced
this pull request
May 17, 2014
FlxAssets.cacheSounds() -> FlxG.sound.cacheAll(), closes #1055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering OpenFL has its own sound cache, I don't think we need the full-blown
FlxG.sound.cache()described in #1055, but it still makes sense to have both of these caching functions in the same place.