Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Module not found" on Code Splitting branch #14

Closed
jcleyba opened this issue Jun 25, 2020 · 4 comments
Closed

"Module not found" on Code Splitting branch #14

jcleyba opened this issue Jun 25, 2020 · 4 comments

Comments

@jcleyba
Copy link

jcleyba commented Jun 25, 2020

I've tried the code splitting branch on two different react/typescript projects and I'm always getting
Module not found: Can't resolve 'react-component-library/build/TestComponent'

One project is a CRA starter and the other a Next.js starter.

Anyone else with the same problem?

@HarveyD
Copy link
Owner

HarveyD commented Jun 25, 2020

I'll have a look at this tonight.

@HarveyD
Copy link
Owner

HarveyD commented Jun 26, 2020

So, it seems the problem is that the rollup-plugin-postcss in combination with Rollup code splitting isn't playing nicely. If you look at the build output, it'll have a src directory with all the compiled code. All the files in src should just be in the top level of build directory.

I'm going to use the rollup-plugin-sass plugin on this branch until I can identify what's going wrong with rollup-plugin-postcss.

@HarveyD
Copy link
Owner

HarveyD commented Jun 26, 2020

I've fix the issue on the branch.

Thank you @jcleyba for raising an issue. You've saved everyone else who was going to use that branch a lot of time!

@jcleyba
Copy link
Author

jcleyba commented Jun 26, 2020

Working as a charm! Thanks for the quick fix @HarveyD. I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants