Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Improve testing coverage of core Halibot class #117

Open
richteer opened this issue Oct 1, 2018 · 0 comments
Open

CI: Improve testing coverage of core Halibot class #117

richteer opened this issue Oct 1, 2018 · 0 comments

Comments

@richteer
Copy link
Contributor

richteer commented Oct 1, 2018

Right now, the core Halibot class has the worst coverage in our testing, and a lot of that is due to how it works. But that shouldn't stop us from writing useless tests anyway!

PR #113 opens up testing ._load_config() and ._write_config() , that should be an easy coverage booster (if you want to branch off that). Some of the other module loading components can probably also be tested in a vacuum, though no idea how some might react. Might be worth writing a test_config.json for some of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant