Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better pause screen options menu #562

Open
axollyon opened this issue Dec 20, 2022 · 11 comments
Open

Better pause screen options menu #562

axollyon opened this issue Dec 20, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request medium priority Semi-important issue or feature / medium priority subjective Multiple opinions are desirable
Milestone

Comments

@axollyon
Copy link
Collaborator

axollyon commented Dec 20, 2022

Create a vanilla-like menu in the pause screen to replace the prompt to press L to switch between widescreen modes.
Potential options to include:

  • Aspect ratio
  • Sound mode
  • Game volumes (I have an implementation of this that I've used for my hacks where you can control the volume of sound effects and background music separately)
  • Language (if MULTILANG is enabled)
    Do not start on this until ASCII/UTF-8 Text and Full Multilang Support #560 is merged.
@axollyon axollyon added enhancement New feature or request medium priority Semi-important issue or feature / medium priority labels Dec 20, 2022
@axollyon axollyon self-assigned this Dec 20, 2022
@axollyon axollyon added this to the 2.1 milestone Dec 20, 2022
@thecozies
Copy link
Contributor

volume control is pretty devisive. SFX is an interesting option though. sound mode is a weird one, we need to remove the headset option so we can get better stereo imaging @gheskett, but then the other option is mono lmao
I'm not really sure what else could be added to this menu outside of game specific things (or camera)

@Reonu
Copy link
Contributor

Reonu commented Dec 20, 2022

mono is good for accesibility, there are people who can't hear in one ear and stuff like that. then again if you're playing on emu you can force mono at an OS level with the accessibility settings there idk

personally I think the mono option should be kept if it's not a burden. if it's annoying to maintain then yeet it

@thecozies
Copy link
Contributor

yeah might as well keep it if @gheskett agrees it's not too bad to have around

@FazanaJ
Copy link
Collaborator

FazanaJ commented Dec 20, 2022

nerds playing on bad tv's only have mono output, plus mono is less CPU usage, so there's definitely merit to keeping mono

@gheskett
Copy link
Collaborator

yeah might as well keep it if @gheskett agrees it's not too bad to have around

As much as it pains me internally, I would agree that mono needs to stay as an option by default.

@gheskett
Copy link
Collaborator

The thing we don't care about is headset, though particularly once I go through and rip out stereo headset effects

@axollyon
Copy link
Collaborator Author

imo if we want to change what sound modes there are, that might be out of scope for this issue, this is just to make that configurable from places other than file select
if we're changing what sound modes we have, that should be a separate pr

@gheskett
Copy link
Collaborator

Yeah sound modes should be a separate PR, but it shouldn't be much more than an hour of work to implement properly. Maybe just wait for that to be ready before worrying about this portion I guess.

@Reonu
Copy link
Contributor

Reonu commented Dec 30, 2022

new option idea: dither filter

could be on/off/auto (auto would automatically disable it when RDP usage gets close to 100% and enable it again once it stays below a set threshold for a certain amount of time, kinda how like dynamic resolution works in modern console games)

if the auto thing is too complicated then a simple on/off is good too but I think auto would be cool

@axollyon
Copy link
Collaborator Author

new option idea: dither filter

could be on/off/auto (auto would automatically disable it when RDP usage gets close to 100% and enable it again once it stays below a set threshold for a certain amount of time, kinda how like dynamic resolution works in modern console games)

if the auto thing is too complicated then a simple on/off is good too but I think auto would be cool

somebody else should be the one to develop that, but i'll take it if only to make the options menu less empty (especially if we don't do volume sliders by default)

@Reonu
Copy link
Contributor

Reonu commented Dec 30, 2022

I mean we could add a simple on/off toggle for now and just have the auto thing noted as a possible future feature

@gheskett gheskett modified the milestones: 2.1, 3.0 Mar 6, 2023
@gheskett gheskett added the subjective Multiple opinions are desirable label Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium priority Semi-important issue or feature / medium priority subjective Multiple opinions are desirable
Projects
Status: To do
Development

No branches or pull requests

5 participants