You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I notice in the readme that you say that if you use Github enterprise you can set the property ATLASSIAN_BAMBOO_GITHUB_API_BASE_URL to point the plugin at your internal github instance. Unfortunately, I think this no longer works as:
a) this plugin (quite reasonably!) only works when your repository type is set to "github" (as opposed to git)
b) When you set your repository type to github, Bamboo will always try and check out your source from "github.com", regardless of what ATLASSIAN_BAMBOO_GITHUB_API_BASE_URL is set to.
Clearly fixing bamboo so it would support github enterprise would be the preferred solution, but I guess that is at the whim of Atlassian. With that in mind I was wondering if it were possible to make this plugin work when the type of the repo was set to git? Obviously we would need some way of distinguishing between repos that are github enterprise (and thus eligible for build status updates) and other git repos (which won't be), but hopefully this can be achieved.
I'm willing to put in a bit of time to help with this if you think it's viable.
The text was updated successfully, but these errors were encountered:
That’s a bummer. I think it’s reasonable to work around this by doing a check to see if the repo’s URL matches either github.com or the system property. Happy to have you contribute this if you would like.
Hi,
I notice in the readme that you say that if you use Github enterprise you can set the property ATLASSIAN_BAMBOO_GITHUB_API_BASE_URL to point the plugin at your internal github instance. Unfortunately, I think this no longer works as:
a) this plugin (quite reasonably!) only works when your repository type is set to "github" (as opposed to git)
b) When you set your repository type to github, Bamboo will always try and check out your source from "github.com", regardless of what ATLASSIAN_BAMBOO_GITHUB_API_BASE_URL is set to.
Clearly fixing bamboo so it would support github enterprise would be the preferred solution, but I guess that is at the whim of Atlassian. With that in mind I was wondering if it were possible to make this plugin work when the type of the repo was set to git? Obviously we would need some way of distinguishing between repos that are github enterprise (and thus eligible for build status updates) and other git repos (which won't be), but hopefully this can be achieved.
I'm willing to put in a bit of time to help with this if you think it's viable.
The text was updated successfully, but these errors were encountered: