Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Github Enterprise #24

Open
d80tb7 opened this issue Mar 24, 2017 · 1 comment
Open

Support for Github Enterprise #24

d80tb7 opened this issue Mar 24, 2017 · 1 comment

Comments

@d80tb7
Copy link

d80tb7 commented Mar 24, 2017

Hi,

I notice in the readme that you say that if you use Github enterprise you can set the property ATLASSIAN_BAMBOO_GITHUB_API_BASE_URL to point the plugin at your internal github instance. Unfortunately, I think this no longer works as:

a) this plugin (quite reasonably!) only works when your repository type is set to "github" (as opposed to git)

b) When you set your repository type to github, Bamboo will always try and check out your source from "github.com", regardless of what ATLASSIAN_BAMBOO_GITHUB_API_BASE_URL is set to.

Clearly fixing bamboo so it would support github enterprise would be the preferred solution, but I guess that is at the whim of Atlassian. With that in mind I was wondering if it were possible to make this plugin work when the type of the repo was set to git? Obviously we would need some way of distinguishing between repos that are github enterprise (and thus eligible for build status updates) and other git repos (which won't be), but hopefully this can be achieved.

I'm willing to put in a bit of time to help with this if you think it's viable.

@HackAttack
Copy link
Owner

That’s a bummer. I think it’s reasonable to work around this by doing a check to see if the repo’s URL matches either github.com or the system property. Happy to have you contribute this if you would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants