Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

achievement modals close themselves rapidly (Rebirth, Streak, maybe others) #9770

Closed
Alys opened this issue Jan 6, 2018 · 4 comments
Closed

Comments

@Alys
Copy link
Contributor

Alys commented Jan 6, 2018

When you use an Orb of Rebirth or get a 21-day streak on a Daily, you see an achievement modal, however the modal closes after a couple of seconds, giving you no time to read it.

The desired behaviour is that it stays open until you click the button at the bottom of it.

citrusella, the serving wench reported it, with this suggestion:
"There's a window that pops up right after you rebirth, but it's impossible to read because Habitica immediately refreshes upon rebirth. Not sure if this is a bug or just an oversight, but... (Maybe a solution is to make the close button the modal the part that refreshes the site? Is that even possible?)"

However the reload isn't relevant to the Streak achievement, so there might need to be two aspects of a fix for this issue (one to make all achievement modals stay open and another to prevent the Rebirth reload until you've closed the modal).

I'm marking this suggestion-discussion for a few days for staff to comment on how they'd like it to be fixed.

@citrusella
Copy link
Contributor

citrusella commented Jan 6, 2018

For what it's worth, the modal never technically closed in my case; rather, the whole page did a full refresh (rather than a sync, it loaded the purple screen with the tip again), so quickly after the action/modal that it wasn't readable.

That is to say, the process was:

  • Click rebirth (which no longer has the information about itself in the purchase modal; is that intended?)
  • Modal pops up with message that includes "this is your [x (i.e. seventh)] rebirth" (the information at that point said it was my seventh, too, so it might not have been current before the refresh)
  • Site did a full refresh before the modal had sat around long enough to be read or even touched

EDIT: Aah, I've been thinking messages didn't say things they actually did say all week. I think I need a break. DX

@TheHollidayInn
Copy link
Contributor

I'm adding tags to this. I think at least for some, we can do the refresh after the confirmation button.

@TheHollidayInn
Copy link
Contributor

@negue Can you apply the snackbar UX to the rebirth and streak achievements for this issue as well?

@Alys
Copy link
Contributor Author

Alys commented Nov 5, 2018

This is probably no longer relevant since there's been several changes to modals since it was logged. The streak achievement modal certainly doesn't close itself.

@Alys Alys closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants