Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popovers misplaced on right side of screen when element doesn't have room to display the full popover (notably on Market and Pets and rewards column screens) #4307

Closed
Alys opened this issue Dec 1, 2014 · 5 comments

Comments

@Alys
Copy link
Contributor

Alys commented Dec 1, 2014

This bug came from #4287, which fixed a more severe bug.

On the Market page, most of the popovers are correctly placed, except for the two right-most columns, in which the popovers are positioned too far right and too far up. It's far worse for the quests than for the other items. The same thing happens with the food on the Pets page.

screen shot 2014-12-01 at 6 09 59 pm

screen shot 2014-12-01 at 6 10 01 pm

screen shot 2014-12-01 at 6 10 03 pm

screen shot 2014-12-01 at 6 10 47 pm

Pets page:

screen shot 2014-12-01 at 6 09 36 pm

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Alys Alys mentioned this issue Dec 1, 2014
@crookedneighbor crookedneighbor changed the title Popovers misplaced on right side of Market and Pets screens Popovers misplaced on right side of screen when element doesn't have room to display the full popover (notably on Market and Pets and rewards column screens) Dec 29, 2014
@brightbold
Copy link

This bug is definitely a bigger deal on the quests. On my computer I can't read the full text of any of the quests in the right-most column, because the tops of the popovers (mmm... popovers!) all fall offscreen, even with the selected quest scroll all the way at the bottom of my viewport.
quest-popup

@crookedneighbor
Copy link
Contributor

This PR will help with this: #4585

But it won't solve it completely:

Good!

screen shot 2015-01-28 at 2 22 46 pm

Still not perfect:

screen shot 2015-01-28 at 2 22 52 pm

@crookedneighbor
Copy link
Contributor

@brightbold the specific issue you pointed out will be fixed the next time a deploy to production is made (should be before the 30th).

@khipkin
Copy link
Contributor

khipkin commented Aug 25, 2016

@Alys Is this still an issue?

@Alys
Copy link
Contributor Author

Alys commented Aug 25, 2016

It sounds fixed and if not, it's covered by this info about a website improvement project: #7799 (comment)

( @khipkin Thanks! I'll cover your other questions like this in several hours after I get back from some tourist time. :) )

@Alys Alys closed this as completed Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants