Improve translations and label generation #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vesameskanen
commented
Oct 4, 2016
•
vesameskanen
commented
- lots of new translations for NLSFI and OSM categories
- 'default' is no longer used as the language for translations. It represents a state where we could not figure out the language, and API should use the preferred real language
- name extensions for label generator no longer overwrite the original name (makes testing more predictable)
- sv neighbourhood and street name translations added
Enlish version is now used as a category in nlsfi import
- use lowercase for NLSFI categories - drop 'default' translations (it is not a language) - add a couple of new translations Problematic 'default' language should be handled by api logic, not by repeating fi translations.
For example, API will not try to return results in 'ru' language unless it is explictly configured in pelias.json config file.
'default' is not a real language, but represents a state where we do not know the language. In such a case, it is wisest to keep the original preferences (api param or lang[0] of pelias config).
Instead, use a new expandedName field to store the more detailed name version. Modifying the actual name can break fuzzy and unit tests.
This fixes mixed names such as 'Borgbacken, Tivolikuja 1, Helsingfors'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.