-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented simple monitor disabling #178
Conversation
Added new switch, --disable/-d that allows monitors to be disabled. Switch can be given multiple times to disable several components. Validity of component name is checked and walllmon cannot be disabled. Added a new test to ensure that the switch fucntions correctly. README.md and help text updated.
There seems to be an issue with our build actions due to a GH security fix. I'll follow up on that. |
I think the codefactor warning can be ignored in this case (it's what we used for ages and injecting a bogus "pstree" into the PATH would just cause prmon to break. (Plus it's the old method, that at some point we can drop.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @graeme-a-stewart. The new functionality looks good to me. I have just a few minor comments.
I resolved the simple conflict through the web interface and the associated https://github.com/HSF/prmon/actions/runs/378656295 We agree to ignore the |
Added new switch, --disable/-d that allows
monitors to be disabled. Switch can be given
multiple times to disable several components.
Validity of component name is checked and
walllmon cannot be disabled.
Added a new test to ensure that the switch
fucntions correctly.
README.md and help text updated.
Closes #107