Convert nvidiamon enc/dec metrics from int to string #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably depends on a combination of the hardware/software/firmware but it looks like an output from
nvidia-smi pmon [...]
of the form:is just as valid as:
Presumably not all metrics, especially
enc
anddec
, are always available.The main problem this creates is that the current implementation of the output parsing doesn't handle the first case well, resulting in all zero values for the
gpu
related metrics. In any case, we currently don't really trackenc
anddec
explicitly. Therefore, I converted their types fromunsigned int
tostd::string
so that the parsing succeeds.This should fix the problem that we've encountered in ADC (gpu related metrics being all zeros).
-s