Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test against expected output fields #152

Closed
graeme-a-stewart opened this issue Jul 15, 2020 · 5 comments · Fixed by #205
Closed

Add test against expected output fields #152

graeme-a-stewart opened this issue Jul 15, 2020 · 5 comments · Fixed by #205
Assignees
Labels
tests Issues to do with tests
Milestone

Comments

@graeme-a-stewart
Copy link
Member

As revealed by #151 we don't check well enough for missing output fields, so we need to add a test for that

@graeme-a-stewart graeme-a-stewart added the tests Issues to do with tests label Jul 15, 2020
@graeme-a-stewart graeme-a-stewart added this to the v2.2 milestone Sep 8, 2020
@graeme-a-stewart graeme-a-stewart modified the milestones: v2.2, v2.3 Jan 27, 2021
@spursbyte
Copy link

hello @graeme-a-stewart can i work on this issue?

@graeme-a-stewart
Copy link
Member Author

Hi @spursbyte - that would be really great. Would it be clear to you how to do this?

@spursbyte
Copy link

spursbyte commented Feb 11, 2021

Hi @spursbyte - that would be really great. Would it be clear to you how to do this?

yes i get the overall view about how to go about the issue.but some more information about it from your side will be highly helpful. and should i start working on it or first make a proposal about it on how i will go about the issue??

@graeme-a-stewart
Copy link
Member Author

Every monitor now defines a paramater_list object (https://github.com/HSF/prmon/blob/master/package/src/parameter.h) that contains the list of parameters and encodes if they will be only output for MAX values or of there is also a meaningful AVG value.

In principle this would then give the values to check against in the text and JSON output files.

I think this is probably better done as a C++ test so that the values to check can be "built in" from the class definitions.

Probably it's best that you think about it then and come up with a proposal that @amete and I can check.

Thanks a lot for your interest in the project!

@spursbyte
Copy link

Every monitor now defines a paramater_list object (https://github.com/HSF/prmon/blob/master/package/src/parameter.h) that contains the list of parameters and encodes if they will be only output for MAX values or of there is also a meaningful AVG value.

In principle this would then give the values to check against in the text and JSON output files.

I think this is probably better done as a C++ test so that the values to check can be "built in" from the class definitions.

Probably it's best that you think about it then and come up with a proposal that @amete and I can check.

Thanks a lot for your interest in the project!

thank for the info and will get started with the proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues to do with tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants