-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test against expected output fields #152
Comments
hello @graeme-a-stewart can i work on this issue? |
Hi @spursbyte - that would be really great. Would it be clear to you how to do this? |
yes i get the overall view about how to go about the issue.but some more information about it from your side will be highly helpful. and should i start working on it or first make a proposal about it on how i will go about the issue?? |
Every monitor now defines a In principle this would then give the values to check against in the text and JSON output files. I think this is probably better done as a C++ test so that the values to check can be "built in" from the class definitions. Probably it's best that you think about it then and come up with a proposal that @amete and I can check. Thanks a lot for your interest in the project! |
thank for the info and will get started with the proposal. |
As revealed by #151 we don't check well enough for missing output fields, so we need to add a test for that
The text was updated successfully, but these errors were encountered: